third_party/WebKit/LayoutTests/fast/events/event-target-passive-histograms.html - Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/event-target-passive-histograms.html

Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ability to test histograms from layout tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5

	6 function silentHistogramCount(bucket)

	7 {

	8 try {

	9 return internals.histogramCount("Event.PassiveForcedEventDispatchBreakage", bucket);

	10 } catch(err) {

	11 }

	12 return 0;

	13 }

	14

	15 test(function() {

	16 window.addEventListener('touchstart', function(e) {

	17 assert_false(e.cancelable);

	18 }, {});

	19

	20 var countBefore = silentHistogramCount(0);

	21 window.dispatchEvent(new TouchEvent('touchstart', {cancelable: false}));

	22 assert_equals(countBefore + 1, silentHistogramCount(0));
	Rick Byers 2016/07/11 14:41:52 nit: rather than use hard-coded bucket values, ple nit: rather than use hard-coded bucket values, please define some constants and mention that they're required to match the enum in the code (just so that someone not intimately familiar with the code can understand the test). dtapuska 2016/07/11 15:46:05 Done. Show quoted text On 2016/07/11 14:41:52, Rick Byers wrote: > nit: rather than use hard-coded bucket values, please define some constants and > mention that they're required to match the enum in the code (just so that > someone not intimately familiar with the code can understand the test). Done.
	23

	24 }, "Not calling prevent default");

	25

	26 test(function() {

	27 window.addEventListener('touchstart', function(e) {

	28 assert_false(e.cancelable);

	29 e.preventDefault();

	30 }, {});

	31

	32 var countBefore = silentHistogramCount(1);

	33 window.dispatchEvent(new TouchEvent('touchstart', {cancelable: false}));

	34 assert_equals(countBefore + 1, silentHistogramCount(1));

	35

	36 }, "Caling prevent default");

	37

	38 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/core.gypi » ('j') | third_party/WebKit/Source/core/events/AddEventListenerOptionsResolved.h » ('J')