Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: extensions/common/features/feature.h

Issue 2137463003: [Extensions] Move Feature channel code into //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/complex_feature.cc ('k') | extensions/common/features/feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/feature.h
diff --git a/extensions/common/features/feature.h b/extensions/common/features/feature.h
index b9f8073a020ea0d7b0028ded400f033ac75d699e..5b85bb28bc280eb0043230b8a0c3eb16d054507d 100644
--- a/extensions/common/features/feature.h
+++ b/extensions/common/features/feature.h
@@ -141,11 +141,6 @@ class Feature {
const GURL& url,
Platform platform) const = 0;
- virtual std::string GetAvailabilityMessage(AvailabilityResult result,
- Manifest::Type type,
- const GURL& url,
- Context context) const = 0;
-
// Returns true if the feature is available to the current environment,
// without needing to know information about an Extension or any other
// contextual information. Typically used when the Feature is purely
@@ -160,9 +155,13 @@ class Feature {
virtual bool IsIdInBlacklist(const std::string& extension_id) const = 0;
virtual bool IsIdInWhitelist(const std::string& extension_id) const = 0;
+ void set_check_channel(bool check_channel) { check_channel_ = check_channel; }
+
protected:
std::string name_;
bool no_parent_;
+ // TODO(devlin): Remove this once we set the feature channel for tests.
+ bool check_channel_;
};
} // namespace extensions
« no previous file with comments | « extensions/common/features/complex_feature.cc ('k') | extensions/common/features/feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698