Storage manager: Update storage usage periodically.

chrome/browser/resources/options/chromeos/storage_manager.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enumeration for device state about remaining space.
  * These values must be kept in sync with
  * StorageManagerHandler::StorageSpaceState in C++ code.
  * @enum {number}
  * @const
@@ skipping 23 matching lines @@
     Page.call(this, 'storage',
               loadTimeData.getString('storageManagerPageTabTitle'),
               'storageManagerPage');
   }
 
   cr.addSingletonGetter(StorageManager);
 
   StorageManager.prototype = {
     __proto__: Page.prototype,
 
+    /**
+     * Timer ID for periodical update.
+     * @type {number}
+     * @private

[Dan Beam, 2016/07/09 00:18:26]

nit: @private {number}

[fukino, 2016/07/11 03:33:24]

Done.

+     */
+    updateTimerId_: -1,
+
     /** @override */
     initializePage: function() {
       Page.prototype.initializePage.call(this);
 
       $('storage-manager-label-downloads').onclick = function() {
         chrome.send('openDownloads');
       };
       $('storage-manager-label-drive-cache').onclick = function() {
         PageManager.showPageByName('storageClearDriveCache');
       };
       $('storage-manager-label-browsing-data').onclick = function() {
         PageManager.showPageByName('clearBrowserData');
       };
       $('storage-manager-label-arc').onclick = function() {
         chrome.send('openArcStorage');
       };
 
       $('storage-confirm').onclick = function() {
         PageManager.closeOverlay();
       };
     },
 
     /** @override */
     didShowPage: function() {
       // Updating storage information can be expensive (e.g. computing directory
       // sizes recursively), so we delay this operation until the page is shown.
       chrome.send('updateStorageInfo');
+      // We periodically update the storage usage while the overlay is visible.
+      this.startPeriodicalUpdate_();
+    },
+
+    /** @override */
+    didClosePage: function() {
+      this.stopPeriodicalUpdate_();
     },
 
     /**
      * Updates the size information (total/used/available) of the internal
      * storage.
      * @param {!options.StorageSizeStat} sizeStat
      * @private
      */
     setSizeStat_: function(sizeStat) {
       $('storage-manager-size-capacity').textContent = sizeStat.totalSize;
@@ skipping 56 matching lines @@
       $('storage-manager-size-arc').textContent = size;
     },
 
     /**
      * Shows the item "Android apps and cache" on the overlay UI.
      * @private
      */
     showArcItem_: function() {
       $('storage-manager-item-arc').hidden = false;
     },
+
+    /**
+     * Starts periodical update for storage usage.
+     * @private
+     */
+    startPeriodicalUpdate_: function() {
+      // We update the storage usage every 5 seconds.
+      if (this.updateTimerId_ === -1) {

[Dan Beam, 2016/07/09 00:18:26]

nit: arguably, you should use == unless there's a Really Good Reason

[fukino, 2016/07/11 03:33:24]

Done for all '===' and '!=='.

+        this.updateTimerId_ = window.setInterval(function() {
+          chrome.send('updateStorageInfo');
+        }, 5000);
+      }
+    },
+
+    /**
+     * Stops periodical update for storage usage.
+     * @private
+     */
+    stopPeriodicalUpdate_: function() {
+      if (this.updateTimerId_ !== -1) {
+        window.clearInterval(this.updateTimerId_);
+        this.updateTimerId_ = -1;
+      }
+    },
   };
 
   // Forward public APIs to private implementations.
   cr.makePublic(StorageManager, [
     'setArcSize',
     'setBrowsingDataSize',
     'setDownloadsSize',
     'setDriveCacheSize',
     'setOtherUsersSize',
     'setSizeStat',
     'showArcItem',
   ]);
 
   return {
     StorageManager: StorageManager
   };
 });