Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2265)

Unified Diff: apps/ui/views/app_window_frame_view.h

Issue 213743017: Remove title and icon from chrome apps native style title bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nicer Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/ui/views/app_window_frame_view.h
diff --git a/apps/ui/views/app_window_frame_view.h b/apps/ui/views/app_window_frame_view.h
index 178147685ae8c72f4dde638a8ae2356f93f5777c..4014b19ba917ecf96f7dbc1a0df1a540470ad788 100644
--- a/apps/ui/views/app_window_frame_view.h
+++ b/apps/ui/views/app_window_frame_view.h
@@ -40,22 +40,26 @@ class AppWindowFrameView : public views::NonClientFrameView,
public:
static const char kViewClassName[];
- explicit AppWindowFrameView();
+ // AppWindowFrameView is used to draw frames for app windows when a non
+ // standard frame is needed. This occurs if there is no frame needed, or if
+ // there is a frame color.
+ // If |draw_frame| is true, the view draws its own window title area and
+ // controls, using |frame_color|. If |draw_frame| is not true, no frame is
+ // drawn.
+ // TODO(benwells): Refactor this to split out frameless and colored frame
+ // views. See http://crbug.com/359432.
+ AppWindowFrameView(views::Widget* widget,
tapted 2014/04/03 19:40:24 I think the separate Init(..) is the prevailing st
benwells 2014/04/04 06:50:43 Done.
+ NativeAppWindow* window,
+ bool draw_frame,
+ const SkColor& frame_color);
virtual ~AppWindowFrameView();
- // Initializes this for |widget|. Sets the number of pixels for which a click
- // is interpreted as a resize for the inner and outer border of the window
- // and the lower-right corner resize handle. If |draw_frame|, the view draws
- // its own window title area and controls, using |frame_color| (otherwise
- // |frame_color| is ignored).
- void Init(views::Widget* widget,
- NativeAppWindow* window,
- bool draw_frame,
- const SkColor& frame_color,
- int resize_inside_bounds_size,
- int resize_outside_bounds_size,
- int resize_outside_scale_for_touch,
- int resize_area_corner_size);
+ void SetResizeSizes(int resize_inside_bounds_size,
+ int resize_outside_bounds_size,
+ int resize_area_corner_size);
+ int resize_inside_bounds_size() {
tapted 2014/04/03 19:40:24 nit: const method?
benwells 2014/04/04 06:50:43 Done.
+ return resize_inside_bounds_size_;
+ };
private:
// views::NonClientFrameView implementation.

Powered by Google App Engine
This is Rietveld 408576698