Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 213743014: Add an extra delay for policy invalidations to be available. (Closed)

Created:
6 years, 8 months ago by Steve Condie
Modified:
6 years, 8 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add an extra delay for policy invalidations to be available. The cloud policy refresh scheduler no longer waits for policy invalidations to become available before issuing the first policy fetch. We want to ensure that any policy change that results from this initial policy fetch is counted as a change without invalidations enabled for metrics purposes. Currently we determine if invalidations are enabled based on whether the invalidation service has reported that it is on. However, there may be a delay between the invalidation service being enabled and the invalidation service actually delivering a pending invalidation. Additionally, on Android the invalidation service always reports that it is enabled. To account for this, add a "grace period" after the invalidation service is enabled during which we still consider invalidations disabled for metrics reporting. BUG=355884 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261506

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -58 lines) Patch
M chrome/browser/policy/cloud/cloud_policy_invalidator.h View 1 6 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.cc View 1 11 chunks +33 lines, -29 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc View 1 8 chunks +48 lines, -23 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_invalidator.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Steve Condie
CL 2 of 3 for crbug.com/355884
6 years, 8 months ago (2014-04-02 00:36:15 UTC) #1
Joao da Silva
lgtm after fixing the comment https://codereview.chromium.org/213743014/diff/1/chrome/browser/policy/cloud/cloud_policy_invalidator.h File chrome/browser/policy/cloud/cloud_policy_invalidator.h (right): https://codereview.chromium.org/213743014/diff/1/chrome/browser/policy/cloud/cloud_policy_invalidator.h#newcode60 chrome/browser/policy/cloud/cloud_policy_invalidator.h:60: base::Clock* clock); Pass this ...
6 years, 8 months ago (2014-04-02 07:16:01 UTC) #2
Steve Condie
https://codereview.chromium.org/213743014/diff/1/chrome/browser/policy/cloud/cloud_policy_invalidator.h File chrome/browser/policy/cloud/cloud_policy_invalidator.h (right): https://codereview.chromium.org/213743014/diff/1/chrome/browser/policy/cloud/cloud_policy_invalidator.h#newcode60 chrome/browser/policy/cloud/cloud_policy_invalidator.h:60: base::Clock* clock); On 2014/04/02 07:16:01, Joao da Silva wrote: ...
6 years, 8 months ago (2014-04-02 18:48:15 UTC) #3
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 8 months ago (2014-04-02 18:50:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/213743014/20001
6 years, 8 months ago (2014-04-02 18:50:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 08:32:38 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 08:32:38 UTC) #7
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 8 months ago (2014-04-03 17:52:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/213743014/20001
6 years, 8 months ago (2014-04-03 17:53:05 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 19:38:51 UTC) #10
Message was sent while issue was closed.
Change committed as 261506

Powered by Google App Engine
This is Rietveld 408576698