Pass GL context bind_generates_resources flag to GPU Service.

content/common/gpu/gpu_command_buffer_stub.cc

Index: content/common/gpu/gpu_command_buffer_stub.cc
diff --git a/content/common/gpu/gpu_command_buffer_stub.cc b/content/common/gpu/gpu_command_buffer_stub.cc
index ef6a45a2e1916e21ed9fc8ba7611a40ea9f23a7c..3767fa9f700354717b945dea4cc27230798fb86a 100644
--- a/content/common/gpu/gpu_command_buffer_stub.cc
+++ b/content/common/gpu/gpu_command_buffer_stub.cc
@@ -139,15 +139,21 @@ GpuCommandBufferStub::GpuCommandBufferStub(
       total_gpu_memory_(0) {
   active_url_hash_ = base::Hash(active_url.possibly_invalid_spec());
   FastSetActiveURL(active_url_, active_url_hash_);
+
+  gpu::gles2::ContextCreationAttribHelper attrib_parser;
+  attrib_parser.Parse(requested_attribs_);
+
   if (share_group) {
     context_group_ = share_group->context_group_;
+    DCHECK(context_group_->bind_generates_resource() ==
+           attrib_parser.bind_generates_resource_);

[Ken Russell (switch to Gerrit), 2014/04/01 21:29:38]

How much testing has this change undergone? Have you verified with a debug build
that ordinary composited content, accelerated 2D canvas content, WebGL content,
Pepper 3D content, etc. all works?

[vmiura, 2014/04/01 22:32:06]

I have manually tested these cases, and observed bind_generates_resource == true
only in the Pepper 3D case.

   } else {
     context_group_ = new gpu::gles2::ContextGroup(
         mailbox_manager,
         image_manager,
         new GpuCommandBufferMemoryTracker(channel),
         NULL,
-        true);
+        attrib_parser.bind_generates_resource_);  // need to pass this in...

[Ken Russell (switch to Gerrit), 2014/04/01 21:29:38]

I don't think the comment adds any value.

Upon further thought, I'd be concerned that some of the client-side contexts in
the same share group might set BIND_GENERATES_RESOURCES and some might not.
Previously this would silently work, since the value coming in from the client
was ignored. Do you know definitively whether or not this is the case?

[vmiura, 2014/04/02 22:12:31]

Removed comment.

   }
 
   use_virtualized_gl_context_ |=