Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2137403002: Rewrite animationtimeline-consistent into animation-playbackRate (Closed)

Created:
4 years, 5 months ago by meade_UTC10
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite animationtimeline-consistent into animation-playbackRate This tests that the animation's currentTime is constant when its playbackRate is 0. This test is intended for upstreaming in interfaces/Animation/playbackRate.html BUG=623437 Committed: https://crrev.com/13e84dff8a9a31764ed276346d78d347458ba125 Cr-Commit-Position: refs/heads/master@{#404795}

Patch Set 1 #

Patch Set 2 : Rename file #

Total comments: 2

Patch Set 3 : Use assert_times_equal instead of assert_approx_equal #

Patch Set 4 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
A third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/animationtimeline-consistent.html View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
meade_UTC10
4 years, 5 months ago (2016-07-12 05:06:10 UTC) #2
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/2137403002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html File third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html (right): https://codereview.chromium.org/2137403002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html#newcode20 third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html:20: assert_approx_equals(animation.currentTime, 0, 0.001); Use assert_times_equal?
4 years, 5 months ago (2016-07-12 05:15:46 UTC) #3
meade_UTC10
https://codereview.chromium.org/2137403002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html File third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html (right): https://codereview.chromium.org/2137403002/diff/20001/third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html#newcode20 third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html:20: assert_approx_equals(animation.currentTime, 0, 0.001); On 2016/07/12 05:15:45, suzyh wrote: > ...
4 years, 5 months ago (2016-07-12 05:57:33 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 06:05:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137403002/60001
4 years, 5 months ago (2016-07-12 06:13:00 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-12 07:43:03 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 07:44:20 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/13e84dff8a9a31764ed276346d78d347458ba125
Cr-Commit-Position: refs/heads/master@{#404795}

Powered by Google App Engine
This is Rietveld 408576698