Adds associated interface support to IPC::Channel

Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500
Committed: https://crrev.com/dc88e5075878f16cde23b910d2ce19aa862129e4
Committed: https://crrev.com/7c6bf9577022c2d646bb6a347d6e3c93a5bb5ac6
Cr-Original-Commit-Position: refs/heads/master@{#405316}
Cr-Commit-Position: refs/heads/master@{#405364}

[Ken Rockot(use gerrit already), 2016-07-12 06:48:56]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 06:49:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 07:14:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 07:14:08]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Ken Rockot(use gerrit already), 2016-07-12 19:22:10]

Description was changed from

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

Part 2 of a series of CLs.

BUG=612500
==========

to

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces:

  1. https://codereview.chromium.org/2136193003
  2. This CL
  3. TBD...
  4. TBD...

BUG=612500
==========

[Ken Rockot(use gerrit already), 2016-07-12 19:22:37]

rockot@chromium.org changed reviewers:
+ yzshen@chromium.org

[Ken Rockot(use gerrit already), 2016-07-12 19:22:38]

And here is part 2, which adds IO-thread associated interface support to the
channel. PTAL!

[yzshen1, 2016-07-13 17:38:42]

The CL doesn't enforce binding associated requests synchronously at the
receiving side. Is there plan to support that? (No saying that it should be done
in this CL.)

https://codereview.chromium.org/2137353002/diff/100001/ipc/ipc_channel.h
File ipc/ipc_channel.h (right):

https://codereview.chromium.org/2137353002/diff/100001/ipc/ipc_channel.h#newc...
ipc/ipc_channel.h:187: 
It seems cleaner to me to group associated interface support into a separate
interface, say, AssociatedInterfaceSupport, and let IPC::Channel have a getter
for that. WDYT?

[Ken Rockot(use gerrit already), 2016-07-13 18:14:22]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 18:15:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-07-13 18:21:15]

On 2016/07/13 at 17:38:42, yzshen wrote:
> The CL doesn't enforce binding associated requests synchronously at the
receiving side. Is there plan to support that? (No saying that it should be done
in this CL.)
> 

I think this will be nice to have to help developers more easily locate errors,
but we should still be able to detect problems since eventually unbound
endpoints will receive messages that we can't dispatch, and that will lead to a
DCHECK failure. WDYT about me adding this later?

> https://codereview.chromium.org/2137353002/diff/100001/ipc/ipc_channel.h
> File ipc/ipc_channel.h (right):
> 
>
https://codereview.chromium.org/2137353002/diff/100001/ipc/ipc_channel.h#newc...
> ipc/ipc_channel.h:187: 
> It seems cleaner to me to group associated interface support into a separate
interface, say, AssociatedInterfaceSupport, and let IPC::Channel have a getter
for that. WDYT?

I like it. Done!

[Ken Rockot(use gerrit already), 2016-07-13 18:21:25]

Description was changed from

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces:

  1. https://codereview.chromium.org/2136193003
  2. This CL
  3. TBD...
  4. TBD...

BUG=612500
==========

to

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500
==========

[yzshen1, 2016-07-13 19:04:18]

On 2016/07/13 18:21:15, Ken Rockot wrote:
> On 2016/07/13 at 17:38:42, yzshen wrote:
> > The CL doesn't enforce binding associated requests synchronously at the
> receiving side. Is there plan to support that? (No saying that it should be
done
> in this CL.)
> > 
> 
> I think this will be nice to have to help developers more easily locate
errors,
> but we should still be able to detect problems since eventually unbound
> endpoints will receive messages that we can't dispatch, and that will lead to
a
> DCHECK failure.

> WDYT about me adding this later?

Sure. I didn't mean to suggest adding that to this CL. Just curious about your
idea on this.



> 
> > https://codereview.chromium.org/2137353002/diff/100001/ipc/ipc_channel.h
> > File ipc/ipc_channel.h (right):
> > 
> >
>
https://codereview.chromium.org/2137353002/diff/100001/ipc/ipc_channel.h#newc...
> > ipc/ipc_channel.h:187: 
> > It seems cleaner to me to group associated interface support into a separate
> interface, say, AssociatedInterfaceSupport, and let IPC::Channel have a getter
> for that. WDYT?
> 
> I like it. Done!

LGTM

[Ken Rockot(use gerrit already), 2016-07-13 19:38:34]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-07-13 20:31:35]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 20:33:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:47:24]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-07-13 21:48:49]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-07-13 21:48:50]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2137353002/#ps160001
(title: "enable tests on non-POSIX as well, fix IPC_EXPORT")

[commit-bot: I haz the power, 2016-07-13 21:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:43:50]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-13 22:46:00]

Description was changed from

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500
==========

to

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500

Committed: https://crrev.com/dc88e5075878f16cde23b910d2ce19aa862129e4
Cr-Commit-Position: refs/heads/master@{#405316}
==========

[commit-bot: I haz the power, 2016-07-13 22:46:02]

Patchset 9 (id:??) landed as
https://crrev.com/dc88e5075878f16cde23b910d2ce19aa862129e4
Cr-Commit-Position: refs/heads/master@{#405316}

[Ken Rockot(use gerrit already), 2016-07-13 22:59:24]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2141253004/ by rockot@chromium.org.

The reason for reverting is: Bah - forgot to update gyp properly. Surprised it
got through the CQ....

[Ken Rockot(use gerrit already), 2016-07-13 23:12:23]

relanding with gyp fixed

[Ken Rockot(use gerrit already), 2016-07-13 23:12:24]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-07-13 23:12:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2137353002/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-07-13 23:13:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:34:24]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-07-14 00:34:43]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 00:35:53]

Description was changed from

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500

Committed: https://crrev.com/dc88e5075878f16cde23b910d2ce19aa862129e4
Cr-Commit-Position: refs/heads/master@{#405316}
==========

to

==========
Adds associated interface support to IPC::Channel

Provides a way of registering associated interface bindings with
an IPC::Channel endpoint and acquiring proxies to remote interfaces
on the other side.

Support for this is exposed by IPC::Channel but only implemented
in IPC::ChannelMojo.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500

Committed: https://crrev.com/dc88e5075878f16cde23b910d2ce19aa862129e4
Committed: https://crrev.com/7c6bf9577022c2d646bb6a347d6e3c93a5bb5ac6
Cr-Original-Commit-Position: refs/heads/master@{#405316}
Cr-Commit-Position: refs/heads/master@{#405364}
==========

[commit-bot: I haz the power, 2016-07-14 00:35:55]

Patchset 11 (id:??) landed as
https://crrev.com/7c6bf9577022c2d646bb6a347d6e3c93a5bb5ac6
Cr-Commit-Position: refs/heads/master@{#405364}