Chromium Code Reviews Chromium Code Reviews
Issue 2137333002:
Prepare animation-cancel-event.html for upstreaming (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html |
| diff --git a/third_party/WebKit/LayoutTests/web-animations-api/player-cancel-event.html b/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html |
| similarity index 78% |
| rename from third_party/WebKit/LayoutTests/web-animations-api/player-cancel-event.html |
| rename to third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html |
| index 5aa72983565df194aede999c4863bf0cc770d989..73e093dcd82aa6c8cac91cebec0e6e4e3c34a285 100644 |
| --- a/third_party/WebKit/LayoutTests/web-animations-api/player-cancel-event.html |
| +++ b/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html |
| @@ -1,12 +1,15 @@ |
| <!DOCTYPE html> |
| -<body> |
| +<meta charset=utf-8> |
| +<title>Canceling an animation: cancel event</title> |
| +<link rel="help" href="https://w3c.github.io/web-animations/#canceling-an-animation-section"> |
| <script src="../resources/testharness.js"></script> |
| <script src="../resources/testharnessreport.js"></script> |
| +<body> |
| <script> |
| var anim1 = document.body.animate([], 100000); |
| var anim2 = document.body.animate([], 100000); |
|
alancutter (OOO until 2018)
2016/07/12 01:45:35
Duration Infinity is probably better.
|
| -var cancelTest = async_test('Cancelling animation should create cancel event.'); |
| +var cancelTest = async_test('Cancelling animation should fire a cancel event.'); |
| var fired = false; |
| anim1.oncancel = function(event) { |
| @@ -28,4 +31,3 @@ anim2.onfinish = function() { |
| anim1.cancel(); |
| anim2.finish(); |
| </script> |
| -</body> |
|
alancutter (OOO until 2018)
2016/07/12 01:45:35
Why remove the closing tag?
dstockwell
2016/07/12 04:56:07
Closing tag does nothing.
|
