Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2137333002: Prepare animation-cancel-event.html for upstreaming (Closed)

Created:
4 years, 5 months ago by dstockwell
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare animation-cancel-event.html for upstreaming BUG=623437 Committed: https://crrev.com/0a76d61ea07af587d99e385e67767f89d55ec19d Cr-Commit-Position: refs/heads/master@{#405090}

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
A + third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html View 1 2 chunks +5 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/player-cancel-event.html View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dstockwell
4 years, 5 months ago (2016-07-12 00:52:22 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 00:55:27 UTC) #3
alancutter (OOO until 2018)
lgtm with nits. https://codereview.chromium.org/2137333002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html File third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html (left): https://codereview.chromium.org/2137333002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html#oldcode31 third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html:31: </body> Why remove the closing tag? ...
4 years, 5 months ago (2016-07-12 01:45:35 UTC) #4
dstockwell
https://codereview.chromium.org/2137333002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html File third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html (left): https://codereview.chromium.org/2137333002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html#oldcode31 third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html:31: </body> On 2016/07/12 at 01:45:35, alancutter wrote: > Why ...
4 years, 5 months ago (2016-07-12 04:56:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137333002/20001
4 years, 5 months ago (2016-07-13 07:29:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 08:47:49 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:49:38 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0a76d61ea07af587d99e385e67767f89d55ec19d
Cr-Commit-Position: refs/heads/master@{#405090}

Powered by Google App Engine
This is Rietveld 408576698