[turbofan] Support subtraction displacements in BaseWithIndexAndDisplacementMatcher

[turbofan] Support subtraction displacements in BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.

BUG=v8:5192
LOG=N

Committed: https://crrev.com/574f6fe127fac2a22c4c909177bf0f3c30085bb0
Cr-Commit-Position: refs/heads/master@{#37701}

[danno, 2016-07-12 08:58:20]

Description was changed from

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code on (ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]
==========

to

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]
==========

[danno, 2016-07-12 08:58:52]

Description was changed from

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]
==========

to

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.
==========

[danno, 2016-07-12 09:45:02]

Description was changed from

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.
==========

to

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.

BUG=v8:5192
LOG=N
==========

[danno, 2016-07-12 11:00:28]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org, epertoso@chromium.org

[danno, 2016-07-12 11:01:46]

ptal

[epertoso, 2016-07-12 15:45:12]

lgtm

[Benedikt Meurer, 2016-07-12 17:45:25]

LGTM, although I dislike the use of bools... so bonus points if you enumerize it
:-)

[danno, 2016-07-13 07:53:58]

Feedback addressed. Bonus points received!

[Benedikt Meurer, 2016-07-13 07:56:44]

Nice, thanks.

[danno, 2016-07-13 07:58:14]

The CQ bit was checked by danno@chromium.org

[danno, 2016-07-13 07:58:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org, bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2137323003/#ps100001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-07-13 07:58:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:00:48]

Description was changed from

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.

BUG=v8:5192
LOG=N
==========

to

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.

BUG=v8:5192
LOG=N
==========

[commit-bot: I haz the power, 2016-07-13 08:00:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-13 08:00:52]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 08:03:50]

Description was changed from

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.

BUG=v8:5192
LOG=N
==========

to

==========
[turbofan] Support subtraction displacements in
BaseWithIndexAndDisplacementMatcher

Previously, the following schedule fragment:

 1: Parameter[0](0)
 2: Parameter[1](0)
 7: Int32Constant[1]
 8: Int32Sub(2, 7)
 9: Load[kRepTagged|kTypeAny](1, 8)

would generate the following code (on ia32):

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 sub eax,0x1
 mov eax,[eax+ecx*1]

Now it generates:

 mov eax,[ebp+0x8]
 mov ecx,[ebp+0xc]
 mov eax,[eax+ecx*1-1]

Similar pattern matching also now works on x64.

BUG=v8:5192
LOG=N

Committed: https://crrev.com/574f6fe127fac2a22c4c909177bf0f3c30085bb0
Cr-Commit-Position: refs/heads/master@{#37701}
==========

[commit-bot: I haz the power, 2016-07-13 08:03:51]

Patchset 6 (id:??) landed as
https://crrev.com/574f6fe127fac2a22c4c909177bf0f3c30085bb0
Cr-Commit-Position: refs/heads/master@{#37701}