Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2137313003: DevTools: remove ElementsTreeElement.updateSelection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 treeElement = this._createElementTreeElement(node); 443 treeElement = this._createElementTreeElement(node);
444 this.appendChild(treeElement); 444 this.appendChild(treeElement);
445 node = node.nextSibling; 445 node = node.nextSibling;
446 } 446 }
447 } 447 }
448 448
449 if (selectedNode) 449 if (selectedNode)
450 this._revealAndSelectNode(selectedNode, true); 450 this._revealAndSelectNode(selectedNode, true);
451 }, 451 },
452 452
453 updateSelection: function()
454 {
455 if (!this.selectedTreeElement)
456 return;
457 var element = this.selectedTreeElement;
458 element.updateSelection();
459 },
460
461 _selectedNodeChanged: function() 453 _selectedNodeChanged: function()
462 { 454 {
463 this.dispatchEventToListeners(WebInspector.ElementsTreeOutline.Events.Se lectedNodeChanged, this._selectedDOMNode); 455 this.dispatchEventToListeners(WebInspector.ElementsTreeOutline.Events.Se lectedNodeChanged, this._selectedDOMNode);
464 }, 456 },
465 457
466 /** 458 /**
467 * @param {!Array.<!WebInspector.DOMNode>} nodes 459 * @param {!Array.<!WebInspector.DOMNode>} nodes
468 */ 460 */
469 _fireElementsTreeUpdated: function(nodes) 461 _fireElementsTreeUpdated: function(nodes)
470 { 462 {
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 if (!this._isValidDragSourceOrTarget(treeElement)) 739 if (!this._isValidDragSourceOrTarget(treeElement))
748 return false; 740 return false;
749 741
750 var node = treeElement.node(); 742 var node = treeElement.node();
751 while (node) { 743 while (node) {
752 if (node === this._treeElementBeingDragged._node) 744 if (node === this._treeElementBeingDragged._node)
753 return false; 745 return false;
754 node = node.parentNode; 746 node = node.parentNode;
755 } 747 }
756 748
757 treeElement.updateSelection();
758 treeElement.listItemElement.classList.add("elements-drag-over"); 749 treeElement.listItemElement.classList.add("elements-drag-over");
759 this._dragOverTreeElement = treeElement; 750 this._dragOverTreeElement = treeElement;
760 event.preventDefault(); 751 event.preventDefault();
761 event.dataTransfer.dropEffect = "move"; 752 event.dataTransfer.dropEffect = "move";
762 return false; 753 return false;
763 }, 754 },
764 755
765 _ondragleave: function(event) 756 _ondragleave: function(event)
766 { 757 {
767 this._clearDragOverTreeElementMarker(); 758 this._clearDragOverTreeElementMarker();
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 _ondragend: function(event) 817 _ondragend: function(event)
827 { 818 {
828 event.preventDefault(); 819 event.preventDefault();
829 this._clearDragOverTreeElementMarker(); 820 this._clearDragOverTreeElementMarker();
830 delete this._treeElementBeingDragged; 821 delete this._treeElementBeingDragged;
831 }, 822 },
832 823
833 _clearDragOverTreeElementMarker: function() 824 _clearDragOverTreeElementMarker: function()
834 { 825 {
835 if (this._dragOverTreeElement) { 826 if (this._dragOverTreeElement) {
836 this._dragOverTreeElement.updateSelection();
837 this._dragOverTreeElement.listItemElement.classList.remove("elements -drag-over"); 827 this._dragOverTreeElement.listItemElement.classList.remove("elements -drag-over");
838 delete this._dragOverTreeElement; 828 delete this._dragOverTreeElement;
839 } 829 }
840 }, 830 },
841 831
842 _contextMenuEventFired: function(event) 832 _contextMenuEventFired: function(event)
843 { 833 {
844 var treeElement = this._treeElementFromEvent(event); 834 var treeElement = this._treeElementFromEvent(event);
845 if (treeElement instanceof WebInspector.ElementsTreeElement) 835 if (treeElement instanceof WebInspector.ElementsTreeElement)
846 this.showContextMenu(treeElement, event); 836 this.showContextMenu(treeElement, event);
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
1249 this._updateModifiedParentNode(node); 1239 this._updateModifiedParentNode(node);
1250 else 1240 else
1251 this._updateModifiedNode(node); 1241 this._updateModifiedNode(node);
1252 } 1242 }
1253 } 1243 }
1254 1244
1255 if (hidePanelWhileUpdating) { 1245 if (hidePanelWhileUpdating) {
1256 this._element.classList.remove("hidden"); 1246 this._element.classList.remove("hidden");
1257 if (originalScrollTop) 1247 if (originalScrollTop)
1258 treeOutlineContainerElement.scrollTop = originalScrollTop; 1248 treeOutlineContainerElement.scrollTop = originalScrollTop;
1259 this.updateSelection();
1260 } 1249 }
1261 1250
1262 this._updateRecords.clear(); 1251 this._updateRecords.clear();
1263 this._fireElementsTreeUpdated(updatedNodes); 1252 this._fireElementsTreeUpdated(updatedNodes);
1264 }, 1253 },
1265 1254
1266 _updateModifiedNode: function(node) 1255 _updateModifiedNode: function(node)
1267 { 1256 {
1268 var treeElement = this.findTreeElement(node); 1257 var treeElement = this.findTreeElement(node);
1269 if (treeElement) 1258 if (treeElement)
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
1756 }, 1745 },
1757 1746
1758 set hovered(x) 1747 set hovered(x)
1759 { 1748 {
1760 if (this._hovered === x) 1749 if (this._hovered === x)
1761 return; 1750 return;
1762 this._hovered = x; 1751 this._hovered = x;
1763 this.listItemElement.classList.toggle("hovered", x); 1752 this.listItemElement.classList.toggle("hovered", x);
1764 }, 1753 },
1765 1754
1766 updateSelection: function()
1767 {
1768 },
1769
1770 /** 1755 /**
1771 * @return {number} 1756 * @return {number}
1772 */ 1757 */
1773 backendNodeId: function() 1758 backendNodeId: function()
1774 { 1759 {
1775 return this._nodeShortcut.deferredNode.backendNodeId(); 1760 return this._nodeShortcut.deferredNode.backendNodeId();
1776 }, 1761 },
1777 1762
1778 /** 1763 /**
1779 * @override 1764 * @override
(...skipping 15 matching lines...) Expand all
1795 if (node) { 1780 if (node) {
1796 this.treeOutline._selectedDOMNode = node; 1781 this.treeOutline._selectedDOMNode = node;
1797 this.treeOutline._selectedNodeChanged(); 1782 this.treeOutline._selectedNodeChanged();
1798 } 1783 }
1799 } 1784 }
1800 return true; 1785 return true;
1801 }, 1786 },
1802 1787
1803 __proto__: TreeElement.prototype 1788 __proto__: TreeElement.prototype
1804 } 1789 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698