Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2137313003: DevTools: remove ElementsTreeElement.updateSelection. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove ElementsTreeElement.updateSelection. BUG=627306 NOTRY=true Committed: https://crrev.com/ae68cede0e568de928c89eea9d5456e4c34d9fcd Cr-Commit-Position: refs/heads/master@{#404852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 10 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 5 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
pfeldman
4 years, 5 months ago (2016-07-12 01:31:00 UTC) #2
lushnikov
lgtm
4 years, 5 months ago (2016-07-12 02:19:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137313003/1
4 years, 5 months ago (2016-07-12 02:25:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260582)
4 years, 5 months ago (2016-07-12 03:49:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137313003/1
4 years, 5 months ago (2016-07-12 21:25:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 22:54:02 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:56:52 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ae68cede0e568de928c89eea9d5456e4c34d9fcd
Cr-Commit-Position: refs/heads/master@{#404852}

Powered by Google App Engine
This is Rietveld 408576698