Issue 2137303002: Allow ChildThreadImpl subclasses to manually start MojoShellConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2137303002: Allow ChildThreadImpl subclasses to manually start MojoShellConnection (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)

Modified:
4 years, 5 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow ChildThreadImpl subclasses to manually start MojoShellConnection Subclasses may want to add ConnectionFilters before the connection is started. Since the connection is normally started in Init, and Init is called from the constructor, we can't use a virtual function to add filters, as is currently done. This adds an option to ChildThreadImpl::Options to allow a subclass to prevent automatic MojoShellConnection start and uses it in RenderthreadImpl. BUG=627253 R=jam@chromium.org

Patch Set 1 #

Patch Set 2 : . #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -20 lines)			Patch
M	content/child/child_thread_impl.h	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	content/child/child_thread_impl.cc	View		4 chunks	+15 lines, -4 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		4 chunks	+15 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

4 years, 5 months ago (2016-07-11 23:02:19 UTC) #2

Closing this because it depends on a patch that I just reverted. I'll roll the
fix into that patch before relanding since it introduced the bug.

Expand Messages | Collapse Messages