Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2137293003: Add metadata and improve descriptions for null keyframe offset test. (Closed)

Created:
4 years, 5 months ago by Andy Mutton
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metadata and improve descriptions for null keyframe offset test. BUG=623437 Committed: https://crrev.com/83dd2ca071ffd12a513320f5cd0ef24e005a77e3 Cr-Commit-Position: refs/heads/master@{#405421}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html View 3 chunks +6 lines, -2 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
Andy Mutton
4 years, 5 months ago (2016-07-12 04:34:01 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/2137293003/diff/1/third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html File third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html (right): https://codereview.chromium.org/2137293003/diff/1/third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html#newcode42 third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html:42: author: 'Alan Cutter', Remove this third parameter.
4 years, 5 months ago (2016-07-12 05:38:38 UTC) #3
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-14 00:57:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137293003/1
4 years, 5 months ago (2016-07-14 00:58:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/255560)
4 years, 5 months ago (2016-07-14 01:28:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137293003/1
4 years, 5 months ago (2016-07-14 01:47:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 02:50:23 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 02:50:25 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 02:52:41 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/83dd2ca071ffd12a513320f5cd0ef24e005a77e3
Cr-Commit-Position: refs/heads/master@{#405421}

Powered by Google App Engine
This is Rietveld 408576698