Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2137243002: Revert of [telemetry] Add support for dispatching key events (Closed)

Created:
4 years, 5 months ago by eakuefner
Modified:
4 years, 5 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [telemetry] Add support for dispatching key events (patchset #3 id:80001 of https://codereview.chromium.org/2122703002/ ) Reason for revert: Broke Catapult roll: crbug.com/627221 for context. Original issue's description: > [telemetry] Add support for dispatching key events > > This enables stories to simulate key presses, e.g.: > > action_runner.PressKey('PageDown') > action_runner.EnterText('This text will be added char-by-char.') > > Rationale: This will allow us to write more complex System Health user > stories. > > BUG=chromium:589726 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/aad076ce2d0def58657d3a31c264bc41b6cfaa07 TBR=nednguyen@google.com,sullivan@chromium.org,aiolos@chromium.org,petrcermak@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:589726 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/157f45aaaabc5adefaebbfb7e2ad536d54f8bfa4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -340 lines) Patch
M telemetry/telemetry/internal/actions/action_runner.py View 2 chunks +0 lines, -26 lines 0 comments Download
M telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 chunk +0 lines, -25 lines 0 comments Download
D telemetry/telemetry/internal/actions/key_event.py View 1 chunk +0 lines, -96 lines 0 comments Download
D telemetry/telemetry/internal/actions/key_event_unittest.py View 1 chunk +0 lines, -83 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py View 1 chunk +0 lines, -69 lines 0 comments Download
M telemetry/telemetry/internal/browser/web_contents.py View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eakuefner
Created Revert of [telemetry] Add support for dispatching key events
4 years, 5 months ago (2016-07-11 20:36:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137243002/1
4 years, 5 months ago (2016-07-11 20:36:54 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 20:37:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698