Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2137203002: [intrinsics] Remove obsolete intrinsics. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Remove obsolete intrinsics. Remove obsolete definitions from macros.py, and drop the now obsolete %_ToPrimitive, %_ToPrimitive_Number, %_ToPrimitive_String, %_ToName and the %ToPrimitive_String intrinsics/runtime entries. R=yangguo@chromium.org BUG=v8:5049 Committed: https://crrev.com/4e862dd9640b15eea7d9738c6afac20d069ac8d8 Cr-Commit-Position: refs/heads/master@{#37665}

Patch Set 1 #

Patch Set 2 : Fix compile error. #

Patch Set 3 : Really nuke TO_NAME. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -194 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 1 chunk +20 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/debug/mirrors.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/js/macros.py View 1 2 4 chunks +0 lines, -19 lines 0 comments Download
M src/js/v8natives.js View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 2 chunks +0 lines, -24 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/to-name.js View 1 chunk +0 lines, -13 lines 0 comments Download
M test/mjsunit/harmony/to-primitive.js View 2 chunks +0 lines, -52 lines 0 comments Download
M test/mjsunit/harmony/to-string.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-11 18:30:38 UTC) #1
Benedikt Meurer
Hey Yang, Some cleanup on the intrinsics. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-11 18:43:12 UTC) #8
Yang
On 2016/07/11 18:43:12, Benedikt Meurer wrote: > Hey Yang, > > Some cleanup on the ...
4 years, 5 months ago (2016-07-12 06:35:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137203002/60001
4 years, 5 months ago (2016-07-12 06:36:00 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-12 06:38:47 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 06:41:33 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e862dd9640b15eea7d9738c6afac20d069ac8d8
Cr-Commit-Position: refs/heads/master@{#37665}

Powered by Google App Engine
This is Rietveld 408576698