Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: trunk/src/chrome/browser/printing/print_preview_dialog_controller.h

Issue 21372006: Revert 212329 "Reland "Close web contents modal dialogs on conte..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/printing/print_preview_dialog_controller.h
===================================================================
--- trunk/src/chrome/browser/printing/print_preview_dialog_controller.h (revision 214772)
+++ trunk/src/chrome/browser/printing/print_preview_dialog_controller.h (working copy)
@@ -1,4 +1,4 @@
- // Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -22,9 +22,9 @@
namespace printing {
-// For print preview, the WebContents that initiates the printing operation is
-// the initiator, and the constrained dialog that shows the print preview is the
-// print preview dialog.
+// For print preview, the tab that initiates the printing operation is the
+// initiator tab, and the constrained dialog that shows the print preview is
+// the print preview dialog.
// This class manages print preview dialog creation and destruction, and keeps
// track of the 1:1 relationship between initiatora tabs and print preview
// dialogs.
@@ -36,14 +36,14 @@
static PrintPreviewDialogController* GetInstance();
- // Initiate print preview for |initiator|.
+ // Initiate print preview for |initiator_tab|.
// Call this instead of GetOrCreatePreviewDialog().
- static void PrintPreview(content::WebContents* initiator);
+ static void PrintPreview(content::WebContents* initiator_tab);
- // Get/Create the print preview dialog for |initiator|.
+ // Get/Create the print preview dialog for |initiator_tab|.
// Exposed for unit tests.
content::WebContents* GetOrCreatePreviewDialog(
- content::WebContents* initiator);
+ content::WebContents* initiator_tab);
// Returns the preview dialog for |contents|.
// Returns |contents| if |contents| is a preview dialog.
@@ -51,9 +51,9 @@
content::WebContents* GetPrintPreviewForContents(
content::WebContents* contents) const;
- // Returns the initiator for |preview_dialog|.
- // Returns NULL if no initiator exists for |preview_dialog|.
- content::WebContents* GetInitiator(content::WebContents* preview_dialog);
+ // Returns the initiator tab for |preview_dialog|.
+ // Returns NULL if no initiator tab exists for |preview_dialog|.
+ content::WebContents* GetInitiatorTab(content::WebContents* preview_dialog);
// content::NotificationObserver implementation.
virtual void Observe(int type,
@@ -66,8 +66,8 @@
// Returns true if |url| is a print preview url.
static bool IsPrintPreviewURL(const GURL& url);
- // Erase the initiator info associated with |preview_dialog|.
- void EraseInitiatorInfo(content::WebContents* preview_dialog);
+ // Erase the initiator tab info associated with |preview_tab|.
+ void EraseInitiatorTabInfo(content::WebContents* preview_tab);
bool is_creating_print_preview_dialog() const {
return is_creating_print_preview_dialog_;
@@ -76,16 +76,9 @@
private:
friend class base::RefCounted<PrintPreviewDialogController>;
- // Used to distinguish between the two varieties of WebContents dealt with by
- // this class.
- enum ContentsType {
- INITIATOR,
- PREVIEW_DIALOG
- };
-
- // 1:1 relationship between a print preview dialog and its initiator.
+ // 1:1 relationship between a print preview dialog and its initiator tab.
// Key: Print preview dialog.
- // Value: Initiator.
+ // Value: Initiator tab.
typedef std::map<content::WebContents*, content::WebContents*>
PrintPreviewDialogMap;
@@ -106,22 +99,21 @@
// Creates a new print preview dialog.
content::WebContents* CreatePrintPreviewDialog(
- content::WebContents* initiator);
+ content::WebContents* initiator_tab);
- // Helper function to store the title of the initiator associated with
+ // Helper function to store the title of the initiator tab associated with
// |preview_dialog| in |preview_dialog|'s PrintPreviewUI.
- void SaveInitiatorTitle(content::WebContents* preview_dialog);
+ void SaveInitiatorTabTitle(content::WebContents* preview_dialog);
// Adds/Removes observers for notifications from |contents|.
- void AddObservers(content::WebContents* contents, ContentsType contents_type);
- void RemoveObservers(content::WebContents* contents,
- ContentsType contents_type);
+ void AddObservers(content::WebContents* contents);
+ void RemoveObservers(content::WebContents* contents);
// Removes WebContents when they close/crash/navigate.
- void RemoveInitiator(content::WebContents* initiator);
+ void RemoveInitiatorTab(content::WebContents* initiator_tab);
void RemovePreviewDialog(content::WebContents* preview_dialog);
- // Mapping between print preview dialog and the corresponding initiator.
+ // Mapping between print preview dialog and the corresponding initiator tab.
PrintPreviewDialogMap preview_dialog_map_;
// A registrar for listening notifications.

Powered by Google App Engine
This is Rietveld 408576698