Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 21372006: Revert 212329 "Reland "Close web contents modal dialogs on conte..." (Closed)

Created:
7 years, 4 months ago by Mike Wittman
Modified:
7 years, 4 months ago
Reviewers:
Mike Wittman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 212329 "Reland "Close web contents modal dialogs on conte..." Causes several problems related to the print preview dialog: http://crbug.com/262023 http://crbug.com/262916 http://crbug.com/265427 > Reland "Close web contents modal dialogs on content load start" > > Address the failure of some web contents modal dialogs to close when > interstitial WebUI is displayed by closing the dialogs on content load start. > Remove existing ad hoc support in dialogs for closing on page loading in favor > of a uniform approach. > > I'm using load start as the trigger for dialog close as this seems to be the > point in time at which the user first perceives the page to be changing. > > Notes on the print preview changes: with this change the dialog is closed when > load starts and the initiator tab gets removed via RemovePreviewDialog, so there > is no longer a need to handle NOTIFICATION_NAV_ENTRY_COMITTED for the initiator > tab. The PrintViewManager::PrintPreviewDone() DCHECK is removed since now > PrintViewManager::RenderViewGone() may be invoked and print_preview_state_ reset > due to WebContents closure before the dialog is destroyed and PrintPreviewDone() > is invoked. > > BUG=240575 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211058 > > Review URL: https://chromiumcodereview.appspot.com/17500003 TBR=wittman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -445 lines) Patch
M trunk/src/chrome/browser/printing/background_printing_manager.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/printing/print_preview_dialog_controller.h View 7 chunks +22 lines, -30 lines 0 comments Download
M trunk/src/chrome/browser/printing/print_preview_dialog_controller.cc View 16 chunks +90 lines, -93 lines 0 comments Download
M trunk/src/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/printing/print_preview_dialog_controller_unittest.cc View 6 chunks +35 lines, -33 lines 0 comments Download
M trunk/src/chrome/browser/printing/print_view_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/repost_form_warning_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/resources/print_preview/native_layer.js View 4 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 3 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 3 chunks +1 line, -17 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.h View 2 chunks +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/tab_modal_confirm_dialog.h View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/tab_modal_confirm_dialog_delegate.h View 4 chunks +10 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/tab_modal_confirm_dialog_views.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 17 chunks +45 lines, -45 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui.h View 4 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 3 chunks +26 lines, -20 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 6 chunks +3 lines, -14 lines 0 comments Download
M trunk/src/components/web_modal/web_contents_modal_dialog_manager.h View 3 chunks +4 lines, -17 lines 0 comments Download
M trunk/src/components/web_modal/web_contents_modal_dialog_manager.cc View 7 chunks +27 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Wittman
7 years, 4 months ago (2013-07-31 17:53:21 UTC) #1
Mike Wittman
Committed patchset #1 manually as r214775.
7 years, 4 months ago (2013-07-31 17:56:09 UTC) #2
Lei Zhang
Doh. Feel free to split the cleanup bits as a separate CL and submit that ...
7 years, 4 months ago (2013-07-31 18:02:05 UTC) #3
Mike Wittman
7 years, 4 months ago (2013-07-31 18:12:06 UTC) #4
Message was sent while issue was closed.
On 2013/07/31 18:02:05, Lei Zhang wrote:
> Doh. Feel free to split the cleanup bits as a separate CL and submit that
> separately.

I think I'll be able to reland by disabling close-on-load-start for print
preview, and preserving the existing behavior. If not, I'll definitely split out
the cleanup as a separate CL.

Powered by Google App Engine
This is Rietveld 408576698