Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2137193002: Update token binding code to latest drafts (Closed)

Created:
4 years, 5 months ago by nharper
Modified:
4 years, 5 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update token binding code to latest drafts - TBPROTO was updated from -06 to -08; no technical changes (this is the version number that is sent over the wire for negotiation). In -04, the EC Point format for public key was clarified; this CL also fixes that format change. - TBNEGO was updated from -02 to -03; no technical changes. - HTTPSTB was updated from -03 to -05; the header name sent by the server signaling that the client should reveal the Token Binding ID used with the referrer. BUG= Committed: https://crrev.com/86f0be236649242ee6bd977a66fe06072a765252 Cr-Commit-Position: refs/heads/master@{#405372}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix EC key format (was changed/clarified in tbproto draft 04) #

Total comments: 2

Patch Set 4 : Remove unnecessary cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M net/socket/ssl_client_socket_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/token_binding.cc View 1 2 3 3 chunks +22 lines, -6 lines 0 comments Download
M net/tools/testserver/testserver.py View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
nharper
4 years, 5 months ago (2016-07-11 18:40:17 UTC) #2
davidben
lgtm When are they going to be done with the busywork of no-op bumping the ...
4 years, 5 months ago (2016-07-11 18:44:07 UTC) #3
nharper
On 2016/07/11 18:44:07, davidben wrote: > lgtm > > When are they going to be ...
4 years, 5 months ago (2016-07-11 18:49:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137193002/1
4 years, 5 months ago (2016-07-11 18:50:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190431)
4 years, 5 months ago (2016-07-11 22:22:47 UTC) #8
nharper
ptal. I added a change to token_binding.cc for how an ECPoint gets written (I missed ...
4 years, 5 months ago (2016-07-13 00:15:18 UTC) #10
davidben
lgtm https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.cc File net/ssl/token_binding.cc (right): https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.cc#newcode177 net/ssl/token_binding.cc:177: memcpy(x9_62_ec_point + 1, reinterpret_cast<const uint8_t*>(ec_point.data()), memcpy takes void* ...
4 years, 5 months ago (2016-07-13 23:22:57 UTC) #11
nharper
https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.cc File net/ssl/token_binding.cc (right): https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.cc#newcode177 net/ssl/token_binding.cc:177: memcpy(x9_62_ec_point + 1, reinterpret_cast<const uint8_t*>(ec_point.data()), On 2016/07/13 23:22:57, davidben ...
4 years, 5 months ago (2016-07-13 23:29:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137193002/60001
4 years, 5 months ago (2016-07-13 23:30:35 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-14 00:49:49 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 00:49:51 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 00:52:28 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/86f0be236649242ee6bd977a66fe06072a765252
Cr-Commit-Position: refs/heads/master@{#405372}

Powered by Google App Engine
This is Rietveld 408576698