Update token binding code to latest drafts

Update token binding code to latest drafts

- TBPROTO was updated from -06 to -08; no technical changes (this is the
  version number that is sent over the wire for negotiation). In -04, the
  EC Point format for public key was clarified; this CL also fixes that
  format change.
- TBNEGO was updated from -02 to -03; no technical changes.
- HTTPSTB was updated from -03 to -05; the header name sent by the
  server signaling that the client should reveal the Token Binding ID
  used with the referrer.

BUG=

Committed: https://crrev.com/86f0be236649242ee6bd977a66fe06072a765252
Cr-Commit-Position: refs/heads/master@{#405372}

[nharper, 2016-07-11 18:40:17]

nharper@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2016-07-11 18:44:07]

lgtm

When are they going to be done with the busywork of no-op bumping the TBPROTO
draft number? This is seriously a waste of everyone's time.

[nharper, 2016-07-11 18:49:34]

On 2016/07/11 18:44:07, davidben wrote:
> lgtm
> 
> When are they going to be done with the busywork of no-op bumping the TBPROTO
> draft number? This is seriously a waste of everyone's time.

Once it reaches WGLC and the wording is just right. It's not bumping the version
number just for the sake of making me write these CLs, but it just so happens
that nothing changes in the wire format.

[nharper, 2016-07-11 18:49:38]

The CQ bit was checked by nharper@chromium.org

[commit-bot: I haz the power, 2016-07-11 18:50:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 22:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 22:22:47]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nharper, 2016-07-13 00:13:37]

Description was changed from

==========
Update token binding code to latest drafts

- TBPROTO was updated from -06 to -08; no technical changes (this is the
  version number that is sent over the wire for negotiation).
- TBNEGO was updated from -02 to -03; no technical changes.
- HTTPSTB was updated from -03 to -05; the header name sent by the
  server signaling that the client should reveal the Token Binding ID
  used with the referrer.

BUG=
==========

to

==========
Update token binding code to latest drafts

- TBPROTO was updated from -06 to -08; no technical changes (this is the
  version number that is sent over the wire for negotiation). In -04, the
  EC Point format for public key was clarified; this CL also fixes that
  format change.
- TBNEGO was updated from -02 to -03; no technical changes.
- HTTPSTB was updated from -03 to -05; the header name sent by the
  server signaling that the client should reveal the Token Binding ID
  used with the referrer.

BUG=
==========

[nharper, 2016-07-13 00:15:18]

ptal. I added a change to token_binding.cc for how an ECPoint gets written (I
missed that in draft 04, it's no longer an X9.62 uncompressed point, but just
raw coordinates).

[davidben, 2016-07-13 23:22:57]

lgtm

https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.cc
File net/ssl/token_binding.cc (right):

https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.c...
net/ssl/token_binding.cc:177: memcpy(x9_62_ec_point + 1, reinterpret_cast<const
uint8_t*>(ec_point.data()),
memcpy takes void* so I think you don't need the cast.

[nharper, 2016-07-13 23:29:43]

https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.cc
File net/ssl/token_binding.cc (right):

https://codereview.chromium.org/2137193002/diff/40001/net/ssl/token_binding.c...
net/ssl/token_binding.cc:177: memcpy(x9_62_ec_point + 1, reinterpret_cast<const
uint8_t*>(ec_point.data()),
On 2016/07/13 23:22:57, davidben wrote:
> memcpy takes void* so I think you don't need the cast.

Done.

[nharper, 2016-07-13 23:29:52]

The CQ bit was checked by nharper@chromium.org

[nharper, 2016-07-13 23:29:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2137193002/#ps60001
(title: "Remove unnecessary cast")

[commit-bot: I haz the power, 2016-07-13 23:30:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:49:48]

Description was changed from

==========
Update token binding code to latest drafts

- TBPROTO was updated from -06 to -08; no technical changes (this is the
  version number that is sent over the wire for negotiation). In -04, the
  EC Point format for public key was clarified; this CL also fixes that
  format change.
- TBNEGO was updated from -02 to -03; no technical changes.
- HTTPSTB was updated from -03 to -05; the header name sent by the
  server signaling that the client should reveal the Token Binding ID
  used with the referrer.

BUG=
==========

to

==========
Update token binding code to latest drafts

- TBPROTO was updated from -06 to -08; no technical changes (this is the
  version number that is sent over the wire for negotiation). In -04, the
  EC Point format for public key was clarified; this CL also fixes that
  format change.
- TBNEGO was updated from -02 to -03; no technical changes.
- HTTPSTB was updated from -03 to -05; the header name sent by the
  server signaling that the client should reveal the Token Binding ID
  used with the referrer.

BUG=
==========

[commit-bot: I haz the power, 2016-07-14 00:49:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-14 00:49:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 00:52:27]

Description was changed from

==========
Update token binding code to latest drafts

- TBPROTO was updated from -06 to -08; no technical changes (this is the
  version number that is sent over the wire for negotiation). In -04, the
  EC Point format for public key was clarified; this CL also fixes that
  format change.
- TBNEGO was updated from -02 to -03; no technical changes.
- HTTPSTB was updated from -03 to -05; the header name sent by the
  server signaling that the client should reveal the Token Binding ID
  used with the referrer.

BUG=
==========

to

==========
Update token binding code to latest drafts

- TBPROTO was updated from -06 to -08; no technical changes (this is the
  version number that is sent over the wire for negotiation). In -04, the
  EC Point format for public key was clarified; this CL also fixes that
  format change.
- TBNEGO was updated from -02 to -03; no technical changes.
- HTTPSTB was updated from -03 to -05; the header name sent by the
  server signaling that the client should reveal the Token Binding ID
  used with the referrer.

BUG=

Committed: https://crrev.com/86f0be236649242ee6bd977a66fe06072a765252
Cr-Commit-Position: refs/heads/master@{#405372}
==========

[commit-bot: I haz the power, 2016-07-14 00:52:28]

Patchset 4 (id:??) landed as
https://crrev.com/86f0be236649242ee6bd977a66fe06072a765252
Cr-Commit-Position: refs/heads/master@{#405372}