Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2137183003:
Add support for dependent types in FOR_EACH_OBSERVER (Closed)
|
Created:
4 years, 5 months ago by Luis Héctor Chávez Modified:
4 years, 5 months ago Reviewers:
dcheng CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd support for dependent types in FOR_EACH_OBSERVER
In the expansion of FOR_EACH_OBSERVER, there is a
base::ObserverListBase<ObserverType>::Iterator. If ObserverType is a
templated type, it won't compile due to a lack of a 'typename'. This
change fixes that.
BUG=627209
TEST=dependent types now compile
Committed: https://crrev.com/89b89baef6868ee3c23c0c68f100179fb03f7217
Cr-Commit-Position: refs/heads/master@{#404980}
Patch Set 1 #
Messages
Total messages: 25 (11 generated)
lhchavez@chromium.org changed reviewers: + dcheng@chromium.org
PTAL Ran into this issue with https://codereview.chromium.org/2133503002/diff/140001/components/arc/instanc... and I wanted to avoid expanding the macro.
lgtm
The CQ bit was checked by lhchavez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lhchavez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lhchavez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lhchavez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lhchavez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Add support for dependent types in FOR_EACH_OBSERVER In the expansion of FOR_EACH_OBSERVER, there is a base::ObserverListBase<ObserverType>::Iterator. If ObserverType is a templated type, it won't compile due to a lack of a 'typename'. This change fixes that. BUG=627209 TEST=dependent types now compile ========== to ========== Add support for dependent types in FOR_EACH_OBSERVER In the expansion of FOR_EACH_OBSERVER, there is a base::ObserverListBase<ObserverType>::Iterator. If ObserverType is a templated type, it won't compile due to a lack of a 'typename'. This change fixes that. BUG=627209 TEST=dependent types now compile Committed: https://crrev.com/89b89baef6868ee3c23c0c68f100179fb03f7217 Cr-Commit-Position: refs/heads/master@{#404980} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/89b89baef6868ee3c23c0c68f100179fb03f7217 Cr-Commit-Position: refs/heads/master@{#404980} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
