Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2137173002: [SPv2] Respect transform-style in the Blink and cc property trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix perspective Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
index 466906e8a5de97fb1bc32f72d39a4f0600b4dadd..4812049a30ed23f5bdd7f787c1690b7c72fb6973 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
@@ -1107,4 +1107,137 @@ TEST_F(PaintPropertyTreeBuilderTest, SvgPixelSnappingShouldResetPaintOffset)
EXPECT_EQ(svgWithTransformProperties->transform(), rectWithTransformProperties->transform()->parent());
}
+TEST_F(PaintPropertyTreeBuilderTest, NoRenderingContextByDefault)
+{
+ setBodyInnerHTML("<div style=\"transform: translateZ(0)\"></div>");
+
+ ObjectPaintProperties* properties = document().body()->firstChild()->layoutObject()->objectPaintProperties();
+ ASSERT_TRUE(properties->transform());
+ EXPECT_FALSE(properties->transform()->hasRenderingContext());
+}
+
+TEST_F(PaintPropertyTreeBuilderTest, Preserve3DCreatesSharedRenderingContext)
+{
+ setBodyInnerHTML(
+ "<div style=\"transform-style: preserve-3d\">"
+ " <div id=\"a\" style=\"transform: translateZ(0)\"></div>"
+ " <div id=\"b\" style=\"transform: translateZ(0)\"></div>"
+ "</div>");
+
+ ObjectPaintProperties* aProperties = document().getElementById("a")->layoutObject()->objectPaintProperties();
+ ObjectPaintProperties* bProperties = document().getElementById("b")->layoutObject()->objectPaintProperties();
+ ASSERT_TRUE(aProperties->transform() && bProperties->transform());
+ EXPECT_NE(aProperties->transform(), bProperties->transform());
+ EXPECT_TRUE(aProperties->transform()->hasRenderingContext());
+ EXPECT_TRUE(bProperties->transform()->hasRenderingContext());
+ EXPECT_EQ(aProperties->transform()->renderingContextRoot(), bProperties->transform()->renderingContextRoot());
+}
+
+TEST_F(PaintPropertyTreeBuilderTest, FlatTransformStyleEndsRenderingContext)
+{
+ setBodyInnerHTML(
+ "<div style=\"transform-style: preserve-3d\">"
+ " <div id=\"a\" style=\"transform: translateZ(0)\">"
+ " <div id=\"b\" style=\"transform: translateZ(0)\"></div>"
+ " </div>"
+ "</div>");
+
+ ASSERT_FALSE(document().getElementById("a")->layoutObject()->styleRef().preserves3D());
+ ObjectPaintProperties* aProperties = document().getElementById("a")->layoutObject()->objectPaintProperties();
+ ObjectPaintProperties* bProperties = document().getElementById("b")->layoutObject()->objectPaintProperties();
+ ASSERT_TRUE(aProperties->transform() && bProperties->transform());
+
+ // #a should participate in a rendering context (due to its parent), but its
+ // child #b should not.
+ EXPECT_TRUE(aProperties->transform()->hasRenderingContext());
+ EXPECT_FALSE(bProperties->transform()->hasRenderingContext());
+}
+
+TEST_F(PaintPropertyTreeBuilderTest, NestedRenderingContexts)
+{
+ setBodyInnerHTML(
+ "<div style=\"transform-style: preserve-3d\">"
+ " <div id=\"a\" style=\"transform: translateZ(0)\">"
+ " <div style=\"transform-style: preserve-3d\">"
+ " <div id=\"b\" style=\"transform: translateZ(0)\">"
+ " </div>"
+ " </div>"
+ "</div>");
+
+ ASSERT_FALSE(document().getElementById("a")->layoutObject()->styleRef().preserves3D());
+ ObjectPaintProperties* aProperties = document().getElementById("a")->layoutObject()->objectPaintProperties();
+ ObjectPaintProperties* bProperties = document().getElementById("b")->layoutObject()->objectPaintProperties();
+ ASSERT_TRUE(aProperties->transform() && bProperties->transform());
+
+ // #a should participate in a rendering context (due to its parent). Its
+ // child does preserve 3D, but since #a does not, #a's rendering context is
+ // not passed on to its children. Thus #b ends up in a separate rendering
+ // context rooted at its parent.
+ EXPECT_TRUE(aProperties->transform()->hasRenderingContext());
+ EXPECT_TRUE(bProperties->transform()->hasRenderingContext());
+ EXPECT_NE(aProperties->transform()->renderingContextRoot(), bProperties->transform()->renderingContextRoot());
+}
+
+TEST_F(PaintPropertyTreeBuilderTest, FlatTransformStylePropagatesToTransformNode)
+{
+ setBodyInnerHTML("<div style=\"transform: translateZ(0)\"></div>");
+
+ ObjectPaintProperties* properties = document().body()->firstChild()->layoutObject()->objectPaintProperties();
+ ASSERT_TRUE(properties->transform());
+ EXPECT_TRUE(properties->transform()->flattensTransform());
+}
+
+TEST_F(PaintPropertyTreeBuilderTest, Preserve3DTransformStylePropagatesToTransformNode)
+{
+ setBodyInnerHTML("<div style=\"transform: translateZ(0); transform-style: preserve-3d\"></div>");
+
+ ObjectPaintProperties* properties = document().body()->firstChild()->layoutObject()->objectPaintProperties();
+ ASSERT_TRUE(properties->transform());
+ EXPECT_TRUE(properties->transform()->preserves3D());
+}
+
+TEST_F(PaintPropertyTreeBuilderTest, PerspectiveIsNotFlattened)
+{
+ // It's necessary to make nodes from the one that applies perspective to
+ // ones that combine with it preserve 3D. Otherwise, the perspective doesn't
+ // do anything.
+ setBodyInnerHTML(
+ "<div id=\"a\" style=\"perspective: 800px\">"
+ " <div id=\"b\" style=\"transform: translateZ(0)\"></div>"
+ "</div>");
+
+ ObjectPaintProperties* aProperties = document().getElementById("a")->layoutObject()->objectPaintProperties();
+ ObjectPaintProperties* bProperties = document().getElementById("b")->layoutObject()->objectPaintProperties();
+ const TransformPaintPropertyNode* aPerspective = aProperties->perspective();
+ ASSERT_TRUE(aPerspective);
+ EXPECT_FALSE(aPerspective->flattensTransform());
+ const TransformPaintPropertyNode* bTransform = bProperties->transform();
+ ASSERT_TRUE(bTransform);
+ EXPECT_TRUE(bTransform->flattensTransform());
+ for (const auto* node = bTransform->parent(); node != aPerspective; node = node->parent()) {
+ ASSERT_TRUE(node);
+ EXPECT_FALSE(node->flattensTransform());
+ }
+}
+
+TEST_F(PaintPropertyTreeBuilderTest, PerspectiveDoesNotEstablishRenderingContext)
+{
+ // It's necessary to make nodes from the one that applies perspective to
+ // ones that combine with it preserve 3D. Otherwise, the perspective doesn't
+ // do anything.
+ setBodyInnerHTML(
+ "<div id=\"a\" style=\"perspective: 800px\">"
+ " <div id=\"b\" style=\"transform: translateZ(0)\"></div>"
+ "</div>");
+
+ ObjectPaintProperties* aProperties = document().getElementById("a")->layoutObject()->objectPaintProperties();
+ ObjectPaintProperties* bProperties = document().getElementById("b")->layoutObject()->objectPaintProperties();
+ const TransformPaintPropertyNode* aPerspective = aProperties->perspective();
+ ASSERT_TRUE(aPerspective);
+ EXPECT_FALSE(aPerspective->hasRenderingContext());
+ const TransformPaintPropertyNode* bTransform = bProperties->transform();
+ ASSERT_TRUE(bTransform);
+ EXPECT_FALSE(bTransform->hasRenderingContext());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698