Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2137163002: Remove unnecessary loop and quit in CronetChunkedOutputStream (Closed)

Created:
4 years, 5 months ago by xunjieli
Modified:
4 years, 5 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary loop and quit in CronetChunkedOutputStream The MessageLoop.loop() in CronetChunkedOutputStream.close() is potentially problematic. If the user closes the OutputStream unintentionally when MessageLoop is not going to be quit, it might wait forever. This removes the corresponding unnecessary quit(). BUG=626653 TBR=pauljensen@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1657103002 Cr-Commit-Position: refs/heads/master@{#404391} (cherry picked from commit 578950706701e926c468cc1ab8128e94bd032e08)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M components/cronet/android/java/src/org/chromium/net/urlconnection/CronetChunkedOutputStream.java View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
xunjieli
4 years, 5 months ago (2016-07-11 17:07:51 UTC) #2
xunjieli
Paul, I am TBR-ing you. This is to merge the change into M53. I verified ...
4 years, 5 months ago (2016-07-11 17:20:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137163002/1
4 years, 5 months ago (2016-07-11 17:26:54 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-11 17:26:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137163002/1
4 years, 5 months ago (2016-07-11 17:31:48 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 17:33:58 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 17:34:07 UTC) #16
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698