Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2137153002:
[Autofill] Implement Impression metric for signin promo in CC dropdown. (Closed)
|
Created:
4 years, 5 months ago by Mathieu Modified:
4 years, 5 months ago CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, asvitkine+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Autofill] Implement Impression metric for signin promo in CC dropdown.
BUG=626442
TEST=AutofillExternalDelegateTest
Committed: https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8
Cr-Commit-Position: refs/heads/master@{#404963}
Patch Set 1 #
Messages
Total messages: 27 (11 generated)
Description was changed from ========== [Autofill] Implement Impression metric for signin promo in CC dropdown. BUG=626442 TEST=AutofillExternalDelegateTest ========== to ========== [Autofill] Implement Impression metric for signin promo in CC dropdown. BUG=626442 TEST=AutofillExternalDelegateTest ==========
mathp@chromium.org changed reviewers: + gogerald@chromium.org, rkaplow@chromium.org
Hi PTAL? rkaplow: metrics gogerals: logic Thanks!
lgtm
Just note that you haven't added "Signin_Impression_FromAutofillDropdown", you probably need to add it here https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr... for Android, and for desktop here https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/inline_lo...
sorry, it's "Signin_Signin_FromAutofillDropdown"
On 2016/07/11 17:19:04, gogerald1 wrote: > sorry, it's "Signin_Signin_FromAutofillDropdown" I have added it for desktop: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/inline_lo... Thanks for tha Android pointer :)
lgtm
The CQ bit was checked by mathp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mathp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mathp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mathp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Autofill] Implement Impression metric for signin promo in CC dropdown. BUG=626442 TEST=AutofillExternalDelegateTest ========== to ========== [Autofill] Implement Impression metric for signin promo in CC dropdown. BUG=626442 TEST=AutofillExternalDelegateTest ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [Autofill] Implement Impression metric for signin promo in CC dropdown. BUG=626442 TEST=AutofillExternalDelegateTest ========== to ========== [Autofill] Implement Impression metric for signin promo in CC dropdown. BUG=626442 TEST=AutofillExternalDelegateTest Committed: https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8 Cr-Commit-Position: refs/heads/master@{#404963} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6dc796c2e1a81908ac9731d549db334617a663b8 Cr-Commit-Position: refs/heads/master@{#404963} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
