Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2137083005: center glyphs for text-on-path-via-rsxform (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
f(malita), djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

center glyphs for text-on-path-via-rsxform BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137083005 Committed: https://skia.googlesource.com/skia/+/7c70d7cfa2be8bb6d36d8df76ba9f967cf019c26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M gm/drawatlas.cpp View 1 chunk +33 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
reed1
take a look at how it appears if offset == 0
4 years, 5 months ago (2016-07-12 03:46:48 UTC) #3
reed1
Seems like we might roll something like this into canvas for all clients that want ...
4 years, 5 months ago (2016-07-12 03:48:29 UTC) #6
f(malita)
lgtm
4 years, 5 months ago (2016-07-12 17:07:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137083005/1
4 years, 5 months ago (2016-07-12 17:30:19 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:06:35 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7c70d7cfa2be8bb6d36d8df76ba9f967cf019c26

Powered by Google App Engine
This is Rietveld 408576698