Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc

Issue 2137083004: Fix overlapping of shelf options on supervised user creation page when rotating screen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert if Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
index 929bc24ba6c919519d96de0d4ff9ed4a2ac2b931..984adf5f1c8e7713da0083796c14afe348050a64 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
@@ -1669,7 +1669,12 @@ void ChromeLauncherControllerImpl::ShelfItemChanged(
// ash::WindowTreeHostManager::Observer:
void ChromeLauncherControllerImpl::OnDisplayConfigurationChanged() {
- SetShelfBehaviorsFromPrefs();
+ // In BOTTOM_LOCKED state, ignore the call of SetShelfBehaviorsFromPrefs.
+ // Because it might be called by some operations, like crbug.com/627040
+ // rotating screen.
+ ash::Shelf* shelf = ash::Shelf::ForPrimaryDisplay();
+ if (!shelf || shelf->alignment() != ash::SHELF_ALIGNMENT_BOTTOM_LOCKED)
+ SetShelfBehaviorsFromPrefs();
}
///////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698