Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2137063004: Prepare animation-effect-timing-easing for upstreaming (Closed)

Created:
4 years, 5 months ago by dstockwell
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare animation-effect-timing-easing for upstreaming BUG=623437

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html View 2 chunks +6 lines, -5 lines 1 comment Download

Messages

Total messages: 12 (3 generated)
dstockwell
4 years, 5 months ago (2016-07-12 00:25:58 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 00:30:06 UTC) #3
alancutter (OOO until 2018)
I think these are already covered by interfaces/Animatable/animate.html, see keyframe-utils.js. https://codereview.chromium.org/2137063004/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html File third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html (right): https://codereview.chromium.org/2137063004/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing.html#newcode26 ...
4 years, 5 months ago (2016-07-12 01:59:35 UTC) #4
dstockwell
On 2016/07/12 at 01:59:35, alancutter wrote: > I think these are already covered by interfaces/Animatable/animate.html, ...
4 years, 5 months ago (2016-07-12 02:11:45 UTC) #5
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-13 07:05:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137063004/1
4 years, 5 months ago (2016-07-13 07:05:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/254831)
4 years, 5 months ago (2016-07-13 08:10:16 UTC) #10
suzyh_UTC10 (ex-contributor)
On 2016/07/13 at 08:10:16, commit-bot wrote: > Try jobs failed on following builders: > win_chromium_rel_ng ...
4 years, 5 months ago (2016-07-13 22:41:16 UTC) #11
suzyh_UTC10 (ex-contributor)
4 years, 5 months ago (2016-07-14 01:06:04 UTC) #12
On 2016/07/13 at 22:41:16, suzyh wrote:
> On 2016/07/13 at 08:10:16, commit-bot wrote:
> > Try jobs failed on following builders:
> >   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> 
> Doug, since test is now failing on Chrome (because the special linear case has
not been removed yet), this test needs an -expected file in order for this patch
to land. Can you add one, please?

Closing in favour of https://codereview.chromium.org/2143973003

Powered by Google App Engine
This is Rietveld 408576698