Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2137063003: Custom formatter popup booleans (Closed)

Created:
4 years, 5 months ago by bmilligan
Modified:
4 years, 5 months ago
Reviewers:
Alan Knight, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated IterableSpan #

Patch Set 3 : Nix fixes #

Patch Set 4 : return type fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -76 lines) Patch
M lib/runtime/dart_sdk.js View 1 8 chunks +43 lines, -34 lines 0 comments Download
M tool/input_sdk/private/debugger.dart View 1 2 3 5 chunks +43 lines, -42 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bmilligan
4 years, 5 months ago (2016-07-11 19:26:28 UTC) #2
Alan Knight
lgtm
4 years, 5 months ago (2016-07-11 19:56:44 UTC) #3
bmilligan
4 years, 5 months ago (2016-07-11 23:21:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
976c024d613d456ec772758dbacf766805d95c4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698