Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2137033002: [regexp] Fix regexp source escaping with preceding backslashes. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix regexp source escaping with preceding backslashes. R=franzih@chromium.org BUG=chromium:515897 Committed: https://crrev.com/bbb2159d4c215e642ca37f2ebff9c0644ea9598c Cr-Commit-Position: refs/heads/master@{#37664}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M src/objects.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-3229.js View 1 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-515897.js View 1 chunk +5 lines, -1 line 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yang
4 years, 5 months ago (2016-07-11 12:20:17 UTC) #1
Franzi
lgtm
4 years, 5 months ago (2016-07-12 05:31:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137033002/20001
4 years, 5 months ago (2016-07-12 05:31:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 05:34:37 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 05:36:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbb2159d4c215e642ca37f2ebff9c0644ea9598c
Cr-Commit-Position: refs/heads/master@{#37664}

Powered by Google App Engine
This is Rietveld 408576698