Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 213703005: Fixed PolicyLoaderIOS unit tests on iOS 6.1. (Closed)

Created:
6 years, 9 months ago by Joao da Silva
Modified:
6 years, 8 months ago
Reviewers:
cmp, dconnelly
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed PolicyLoaderIOS unit tests on iOS 6.1. These tests and the feature that they test rely on iOS 7 APIs. This change skips those tests if the platform is not recent enough. BUG=348820 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M components/policy/core/common/policy_loader_ios_unittest.mm View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
PTAL. This is upstreaming the same change that went downstream.
6 years, 9 months ago (2014-03-27 18:14:15 UTC) #1
dconnelly
lgtm
6 years, 9 months ago (2014-03-27 19:23:42 UTC) #2
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-28 00:51:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/213703005/1
6 years, 9 months ago (2014-03-28 00:52:34 UTC) #4
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:36:45 UTC) #5
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:40:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/213703005/1
6 years, 8 months ago (2014-03-30 16:40:34 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 20:40:23 UTC) #8
Message was sent while issue was closed.
Change committed as 260460

Powered by Google App Engine
This is Rietveld 408576698