Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: content/browser/media/webrtc_internals_unittest.cc

Issue 213703004: Ensure that WebRTC AEC recording checkbox is not set if cancelling file dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review fixes + rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/webrtc_internals_unittest.cc
diff --git a/content/browser/media/webrtc_internals_unittest.cc b/content/browser/media/webrtc_internals_unittest.cc
index e8fe15e906083bb4e3ce201014aeed69aee8ee37..e4b0531fa54f160d064433d0acf9ca8d97d33a5b 100644
--- a/content/browser/media/webrtc_internals_unittest.cc
+++ b/content/browser/media/webrtc_internals_unittest.cc
@@ -23,7 +23,8 @@ class MockWebRTCInternalsProxy : public WebRTCInternalsUIObserver {
virtual void OnUpdate(const std::string& command,
const base::Value* value) OVERRIDE {
command_ = command;
- value_.reset(value->DeepCopy());
+ if (value)
+ value_.reset(value->DeepCopy());
}
std::string command() {
@@ -270,4 +271,12 @@ TEST_F(WebRTCInternalsTest, OnAddStats) {
VerifyList(dict, "reports", list);
}
+TEST_F(WebRTCInternalsTest, AecRecordingFileSelectionCanceled) {
+ scoped_ptr<MockWebRTCInternalsProxy> observer(new MockWebRTCInternalsProxy());
+ WebRTCInternals::GetInstance()->AddObserver(observer.get());
+ WebRTCInternals::GetInstance()->FileSelectionCanceled(NULL);
+ EXPECT_EQ("aecRecordingFileSelectionCancelled", observer->command());
+ EXPECT_EQ(NULL, observer->value());
+}
+
} // namespace content
« no previous file with comments | « content/browser/media/webrtc_internals_ui_observer.h ('k') | content/browser/resources/media/dump_creator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698