content/browser/resources/media/dump_creator.js - Issue 213703004: Ensure that WebRTC AEC recording checkbox is not set if cancelling file dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/resources/media/dump_creator.js

Issue 213703004: Ensure that WebRTC AEC recording checkbox is not set if cancelling file dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/webrtc_internals_ui_observer.h ('K') | « content/browser/media/webrtc_internals_unittest.cc ('k') | content/browser/resources/media/webrtc_internals.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/resources/media/dump_creator.js

diff --git a/content/browser/resources/media/dump_creator.js b/content/browser/resources/media/dump_creator.js

index 33abe57e1e845a4463b479bf82a302170901215e..eda629f345c3fe0cb5bd5de74b1ec99759c941df 100644

--- a/content/browser/resources/media/dump_creator.js

+++ b/content/browser/resources/media/dump_creator.js

@@ -60,6 +60,11 @@ var DumpCreator = (function() {

this.root_.getElementsByTagName('input')[0].checked = true;

+ /** Mark the AEC recording checkbox unchecked.*/

Ami GONE FROM CHROMIUM 2014/03/27 19:04:53 Why /** instead of /*, or, more likely, just // ?

Henrik Grunell 2014/03/28 09:06:01 Agree, done.

+ aecRecordingFileSelectionCancelled: function() {

Ami GONE FROM CHROMIUM 2014/03/27 19:04:53 not just "disableAecRecording"?

Henrik Grunell 2014/03/28 09:06:01 Agree, done.

+ this.root_.getElementsByTagName('input')[0].checked = false;

+ },

/**

* Downloads the PeerConnection updates and stats data as a file.