Ensure that WebRTC AEC recording checkbox is not set if cancelling file dialog.

content/browser/resources/media/dump_creator.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * Provides the UI for dump creation.
  */
 var DumpCreator = (function() {
   /**
@@ skipping 42 matching lines @@
     content.getElementsByTagName('input')[0].addEventListener(
         'click', this.onAecRecordingChanged_.bind(this));
   }
 
   DumpCreator.prototype = {
     /** Mark the AEC recording checkbox checked.*/
     enableAecRecording: function() {
       this.root_.getElementsByTagName('input')[0].checked = true;
     },
 
+    /** Mark the AEC recording checkbox unchecked.*/

[Ami GONE FROM CHROMIUM, 2014/03/27 19:04:53]

Why /** instead of /*, or, more likely, just // ?

(/** means jsdoc AFAIK, but you don't really want this or l.58 being jsdoc'd, do
you?)

[Henrik Grunell, 2014/03/28 09:06:01]

Agree, done.

+    aecRecordingFileSelectionCancelled: function() {

[Ami GONE FROM CHROMIUM, 2014/03/27 19:04:53]

not just "disableAecRecording"?

[Henrik Grunell, 2014/03/28 09:06:01]

Agree, done.

+      this.root_.getElementsByTagName('input')[0].checked = false;
+    },
+
     /**
      * Downloads the PeerConnection updates and stats data as a file.
      *
      * @private
      */
     onDownloadData_: function() {
       var dump_object =
       {
         'getUserMedia': userMediaRequests,
         'PeerConnections': peerConnectionDataStore,
@@ skipping 15 matching lines @@
       var enabled = this.root_.getElementsByTagName('input')[0].checked;
       if (enabled) {
         chrome.send('enableAecRecording');
       } else {
         chrome.send('disableAecRecording');
       }
     },
   };
   return DumpCreator;
 })();