Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2137023002: Removed the disused WEBRTC_IDENTITY datatype from BrowsingDataRemover (Closed)

Created:
4 years, 5 months ago by msramek
Modified:
4 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, markusheintz_, msramek+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed the disused WEBRTC_IDENTITY datatype from BrowsingDataRemover This datatype was disused in https://codereview.chromium.org/2033353002/, but not completely removed. BUG=webrtc:5708 Committed: https://crrev.com/0cf3465eb97c51bb99d2fb5536818781b4bd121e Cr-Commit-Position: refs/heads/master@{#404640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 4 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
msramek
Hi guys, please have a look! Thanks, Martin
4 years, 5 months ago (2016-07-11 11:58:29 UTC) #2
hbos_chromium
Thanks, I missed that one! LGTM
4 years, 5 months ago (2016-07-11 12:21:11 UTC) #3
Mike West
On 2016/07/11 at 12:21:11, hbos wrote: > Thanks, I missed that one! > > LGTM ...
4 years, 5 months ago (2016-07-11 12:24:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137023002/1
4 years, 5 months ago (2016-07-11 12:25:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 12:33:55 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 12:34:15 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 12:37:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cf3465eb97c51bb99d2fb5536818781b4bd121e
Cr-Commit-Position: refs/heads/master@{#404640}

Powered by Google App Engine
This is Rietveld 408576698