Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: extensions/browser/api/sockets_udp/sockets_udp_api.cc

Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/sockets_udp/sockets_udp_api.cc
diff --git a/extensions/browser/api/sockets_udp/sockets_udp_api.cc b/extensions/browser/api/sockets_udp/sockets_udp_api.cc
index 9e2e607a4bdcef3cf4ea9e7a724f5f38ba095634..05ef6620e93f70a6d8c4b2f193f492f14d68a633 100644
--- a/extensions/browser/api/sockets_udp/sockets_udp_api.cc
+++ b/extensions/browser/api/sockets_udp/sockets_udp_api.cc
@@ -75,13 +75,13 @@ sockets_udp::SocketInfo CreateSocketInfo(int socket_id,
void SetSocketProperties(ResumableUDPSocket* socket,
sockets_udp::SocketProperties* properties) {
if (properties->name.get()) {
- socket->set_name(*properties->name.get());
+ socket->set_name(*properties->name);
}
if (properties->persistent.get()) {
- socket->set_persistent(*properties->persistent.get());
+ socket->set_persistent(*properties->persistent);
}
if (properties->buffer_size.get()) {
- socket->set_buffer_size(*properties->buffer_size.get());
+ socket->set_buffer_size(*properties->buffer_size);
}
}
@@ -98,7 +98,7 @@ bool SocketsUdpCreateFunction::Prepare() {
void SocketsUdpCreateFunction::Work() {
ResumableUDPSocket* socket = new ResumableUDPSocket(extension_->id());
- sockets_udp::SocketProperties* properties = params_.get()->properties.get();
+ sockets_udp::SocketProperties* properties = params_->properties.get();
if (properties) {
SetSocketProperties(socket, properties);
}
@@ -125,7 +125,7 @@ void SocketsUdpUpdateFunction::Work() {
return;
}
- SetSocketProperties(socket, &params_.get()->properties);
+ SetSocketProperties(socket, &params_->properties);
results_ = sockets_udp::Update::Results::Create();
}
« no previous file with comments | « extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc ('k') | extensions/browser/api/usb/usb_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698