Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2137013004: Re-add the path() method of WebKitPatch. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add the path() method of WebKitPatch. The path() method was removed in http://crrev.com/2110893003 because I thought it was unnecessary; it turns out it's used by rebaseline commands to construct the command used to invoke other commands. BUG=621181 Committed: https://crrev.com/2d234ea5f6eab8653bfb256408776a0fa4a8af3b Cr-Commit-Position: refs/heads/master@{#404747}

Patch Set 1 #

Patch Set 2 : Update unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M third_party/WebKit/Tools/Scripts/webkit-patch View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch_unittest.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
qyearsley
4 years, 5 months ago (2016-07-11 18:32:48 UTC) #2
wkorman
lgtm
4 years, 5 months ago (2016-07-11 18:35:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137013004/20001
4 years, 5 months ago (2016-07-11 22:00:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 00:10:21 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2d234ea5f6eab8653bfb256408776a0fa4a8af3b Cr-Commit-Position: refs/heads/master@{#404747}
4 years, 5 months ago (2016-07-12 00:14:01 UTC) #13
Dirk Pranke
4 years, 4 months ago (2016-08-09 03:50:25 UTC) #14
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698