Chromium Code Reviews| Index: third_party/WebKit/public/platform/WebTraceLocation.h |
| diff --git a/third_party/WebKit/public/platform/WebTraceLocation.h b/third_party/WebKit/public/platform/WebTraceLocation.h |
| index 3203f0805ae85ceb1534ec0937db30927a3605c4..1282fb4a9a52a7b245ec622ef2bcb59320f67264 100644 |
| --- a/third_party/WebKit/public/platform/WebTraceLocation.h |
| +++ b/third_party/WebKit/public/platform/WebTraceLocation.h |
| @@ -14,18 +14,23 @@ namespace blink { |
| class BLINK_PLATFORM_EXPORT WebTraceLocation { |
| public: |
| // These char*s are not copied and must live for the duration of the program. |
| - WebTraceLocation(const char* function, const char* file); |
| + WebTraceLocation(const char* function, const char* file, int lineNumber, const void* programCounter); |
| WebTraceLocation(); |
| + static const void* getProgramCounter(); |
| const char* functionName() const; |
| const char* fileName() const; |
| + int lineNumber() const; |
| + const void* programCounter() const; |
| private: |
| const char* m_functionName; |
| const char* m_fileName; |
| + int m_lineNumber; |
| + const void* m_programCounter; |
| }; |
| -#define BLINK_FROM_HERE ::blink::WebTraceLocation(__FUNCTION__, __FILE__) |
| +#define BLINK_FROM_HERE ::blink::WebTraceLocation(__FUNCTION__, __FILE__, __LINE__, ::blink::WebTraceLocation::getProgramCounter()) |
|
kinuko
2016/07/14 05:51:14
Can't we just call tracked_objects::GetProgramCoun
tzik
2016/07/14 07:51:06
I think I don't understand our latest layering pol
alex clarke (OOO till 29th)
2016/07/14 10:20:48
IMO It seems like it would be a good idea to try a
|
| } |