Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: components/scheduler/child/web_scheduler_impl.cc

Issue 2137013002: Make WebTraceLocation be an alias of tracked_objects::Location (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: +#include <intrin.h> Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/child/web_scheduler_impl.cc
diff --git a/components/scheduler/child/web_scheduler_impl.cc b/components/scheduler/child/web_scheduler_impl.cc
index cc1a2ecc65c1f796aee74f32d77ee7d7ddd4e313..8eda8dc34336b80ac14f97ad51b93fc85efa7a79 100644
--- a/components/scheduler/child/web_scheduler_impl.cc
+++ b/components/scheduler/child/web_scheduler_impl.cc
@@ -50,7 +50,9 @@ void WebSchedulerImpl::postIdleTask(const blink::WebTraceLocation& web_location,
DCHECK(idle_task_runner_);
std::unique_ptr<blink::WebThread::IdleTask> scoped_task(task);
tracked_objects::Location location(web_location.functionName(),
- web_location.fileName(), -1, nullptr);
+ web_location.fileName(),
+ web_location.lineNumber(),
+ web_location.programCounter());
kinuko 2016/07/14 05:51:14 Why don't we just have operator tracked_objects::L
tzik 2016/07/14 07:51:06 Done.
idle_task_runner_->PostIdleTask(
location,
base::Bind(&WebSchedulerImpl::runIdleTask, base::Passed(&scoped_task)));
@@ -62,7 +64,9 @@ void WebSchedulerImpl::postNonNestableIdleTask(
DCHECK(idle_task_runner_);
std::unique_ptr<blink::WebThread::IdleTask> scoped_task(task);
tracked_objects::Location location(web_location.functionName(),
- web_location.fileName(), -1, nullptr);
+ web_location.fileName(),
+ web_location.lineNumber(),
+ web_location.programCounter());
idle_task_runner_->PostNonNestableIdleTask(
location,
base::Bind(&WebSchedulerImpl::runIdleTask, base::Passed(&scoped_task)));
@@ -74,7 +78,9 @@ void WebSchedulerImpl::postIdleTaskAfterWakeup(
DCHECK(idle_task_runner_);
std::unique_ptr<blink::WebThread::IdleTask> scoped_task(task);
tracked_objects::Location location(web_location.functionName(),
- web_location.fileName(), -1, nullptr);
+ web_location.fileName(),
+ web_location.lineNumber(),
+ web_location.programCounter());
idle_task_runner_->PostIdleTaskAfterWakeup(
location,
base::Bind(&WebSchedulerImpl::runIdleTask, base::Passed(&scoped_task)));

Powered by Google App Engine
This is Rietveld 408576698