Make WebTraceLocation be an alias of tracked_objects::Location

Make WebTraceLocation be an alias of tracked_objects::Location

Make WebTraceLocation be an alias of tracked_objects::Location and
BLINK_FROM_HERE be an alias of FROM_HERE as well. So that tasks posted
from Blink leaves a valid program counter and line number in the crash
dump.

Committed: https://crrev.com/3c109dd65c1984237444da93f7c7acc8b0bdcd92
Cr-Commit-Position: refs/heads/master@{#405736}

[tzik, 2016-07-14 04:15:22]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 04:15:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-14 05:15:39]

Description was changed from

==========
Add the line number and program counter to BLINK_FROM_HERE

BUG=
==========

to

==========
Add the line number and program counter to BLINK_FROM_HERE

The program counter in FROM_HERE is valuable on debugging on minidump,
though it's missing when the task is posted from Blink. This CL adds and
fills up m_lineNumber and m_programCounter field in WebTraceLocation
struct created by BLINK_FROM_HERE.
==========

[tzik, 2016-07-14 05:25:48]

tzik@chromium.org changed reviewers:
+ alexclarke@chromium.org, kinuko@chromium.org, tkent@chromium.org

[tzik, 2016-07-14 05:31:33]

PTAL to:
alexclarke: //component/scheduler part
tkent: blink/platform and //component/test_runner part
kinuko: //content

[tkent, 2016-07-14 05:40:19]

Is it difficult to switch BLINK_FROM_HERE to FROM_HERE?

[kinuko, 2016-07-14 05:51:14]

https://codereview.chromium.org/2137013002/diff/20001/components/scheduler/ch...
File components/scheduler/child/web_scheduler_impl.cc (right):

https://codereview.chromium.org/2137013002/diff/20001/components/scheduler/ch...
components/scheduler/child/web_scheduler_impl.cc:55:
web_location.programCounter());
Why don't we just have operator tracked_objects::Location for WebLocation? (Like
what we have for string16 <-> WebString)

https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebTraceLocation.h (right):

https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebTraceLocation.h:33: #define
BLINK_FROM_HERE ::blink::WebTraceLocation(__FUNCTION__, __FILE__, __LINE__,
::blink::WebTraceLocation::getProgramCounter())
Can't we just call tracked_objects::GetProgramCounter()?

[commit-bot: I haz the power, 2016-07-14 06:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 06:23:32]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tzik, 2016-07-14 07:30:49]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 07:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-14 07:35:52]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 07:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-14 07:51:05]

tzik@chromium.org changed reviewers:
+ esprehn@chromium.org

[tzik, 2016-07-14 07:51:06]

https://codereview.chromium.org/2137013002/diff/20001/components/scheduler/ch...
File components/scheduler/child/web_scheduler_impl.cc (right):

https://codereview.chromium.org/2137013002/diff/20001/components/scheduler/ch...
components/scheduler/child/web_scheduler_impl.cc:55:
web_location.programCounter());
On 2016/07/14 05:51:14, kinuko wrote:
> Why don't we just have operator tracked_objects::Location for WebLocation?
(Like
> what we have for string16 <-> WebString)

Done.

https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebTraceLocation.h (right):

https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebTraceLocation.h:33: #define
BLINK_FROM_HERE ::blink::WebTraceLocation(__FUNCTION__, __FILE__, __LINE__,
::blink::WebTraceLocation::getProgramCounter())
On 2016/07/14 05:51:14, kinuko wrote:
> Can't we just call tracked_objects::GetProgramCounter()?

On 2016/07/14 05:40:19, tkent wrote:
> Is it difficult to switch BLINK_FROM_HERE to FROM_HERE?

I think I don't understand our latest layering policy...
+esprehn. Can we use //base in public/platform header?

[commit-bot: I haz the power, 2016-07-14 08:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 08:20:51]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[alex clarke (OOO till 29th), 2016-07-14 10:20:48]

Thanks! I this patch will make it easier to understand where blink tasks come
from in tracing.

The scheduler/ changes look fine.

https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebTraceLocation.h (right):

https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebTraceLocation.h:33: #define
BLINK_FROM_HERE ::blink::WebTraceLocation(__FUNCTION__, __FILE__, __LINE__,
::blink::WebTraceLocation::getProgramCounter())
On 2016/07/14 07:51:06, tzik wrote:
> On 2016/07/14 05:51:14, kinuko wrote:
> > Can't we just call tracked_objects::GetProgramCounter()?
> 
> On 2016/07/14 05:40:19, tkent wrote:
> > Is it difficult to switch BLINK_FROM_HERE to FROM_HERE?
> 
> I think I don't understand our latest layering policy...
> +esprehn. Can we use //base in public/platform header?

IMO It seems like it would be a good idea to try and use FROM_HERE if possible.

[tzik, 2016-07-14 11:16:10]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 11:16:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-14 11:20:35]

On 2016/07/14 10:20:48, alex clarke wrote:
> Thanks! I this patch will make it easier to understand where blink tasks come
> from in tracing.
> 
> The scheduler/ changes look fine.
> 
>
https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
> File third_party/WebKit/public/platform/WebTraceLocation.h (right):
> 
>
https://codereview.chromium.org/2137013002/diff/20001/third_party/WebKit/publ...
> third_party/WebKit/public/platform/WebTraceLocation.h:33: #define
> BLINK_FROM_HERE ::blink::WebTraceLocation(__FUNCTION__, __FILE__, __LINE__,
> ::blink::WebTraceLocation::getProgramCounter())
> On 2016/07/14 07:51:06, tzik wrote:
> > On 2016/07/14 05:51:14, kinuko wrote:
> > > Can't we just call tracked_objects::GetProgramCounter()?
> > 
> > On 2016/07/14 05:40:19, tkent wrote:
> > > Is it difficult to switch BLINK_FROM_HERE to FROM_HERE?
> > 
> > I think I don't understand our latest layering policy...
> > +esprehn. Can we use //base in public/platform header?
> 
> IMO It seems like it would be a good idea to try and use FROM_HERE if
possible.

OK, I updated the CL. PS4 makes WebTraceLocation be an alias of
tracked_objects::Location.
WDYT?

[commit-bot: I haz the power, 2016-07-14 11:35:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 11:35:58]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[tzik, 2016-07-14 13:26:23]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 13:26:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 14:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 14:31:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kinuko, 2016-07-14 23:34:43]

lgtm

[esprehn, 2016-07-14 23:55:46]

This seems reasonable, lgtm.

platform can depend on base/ as needed, especially when it simplifies code and
removes duplication without impacting performance (ex. introducing std::string
copies or some such).

[tkent, 2016-07-15 00:01:38]

third_party/WebKit and test_runner lgtm

[tzik, 2016-07-15 00:43:28]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 00:44:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-15 00:56:56]

Description was changed from

==========
Add the line number and program counter to BLINK_FROM_HERE

The program counter in FROM_HERE is valuable on debugging on minidump,
though it's missing when the task is posted from Blink. This CL adds and
fills up m_lineNumber and m_programCounter field in WebTraceLocation
struct created by BLINK_FROM_HERE.
==========

to

==========
Make WebTraceLocation be an alias of tracked_objects::Location

Make WebTraceLocation be an alias of tracked_objects::Location and
BLINK_FROM_HERE be an alias of FROM_HERE as well. So that tasks posted
from Blink leaves a valid program counter and line number in the crash
dump.
==========

[commit-bot: I haz the power, 2016-07-15 03:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 03:58:06]

Dry run: This issue passed the CQ dry run.

[alex clarke (OOO till 29th), 2016-07-15 09:26:13]

scheduler/ LGTM

[tzik, 2016-07-15 09:45:36]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-07-15 09:45:37]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
tkent@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2137013002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-15 09:45:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 09:51:19]

Description was changed from

==========
Make WebTraceLocation be an alias of tracked_objects::Location

Make WebTraceLocation be an alias of tracked_objects::Location and
BLINK_FROM_HERE be an alias of FROM_HERE as well. So that tasks posted
from Blink leaves a valid program counter and line number in the crash
dump.
==========

to

==========
Make WebTraceLocation be an alias of tracked_objects::Location

Make WebTraceLocation be an alias of tracked_objects::Location and
BLINK_FROM_HERE be an alias of FROM_HERE as well. So that tasks posted
from Blink leaves a valid program counter and line number in the crash
dump.
==========

[commit-bot: I haz the power, 2016-07-15 09:51:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-15 09:53:17]

Description was changed from

==========
Make WebTraceLocation be an alias of tracked_objects::Location

Make WebTraceLocation be an alias of tracked_objects::Location and
BLINK_FROM_HERE be an alias of FROM_HERE as well. So that tasks posted
from Blink leaves a valid program counter and line number in the crash
dump.
==========

to

==========
Make WebTraceLocation be an alias of tracked_objects::Location

Make WebTraceLocation be an alias of tracked_objects::Location and
BLINK_FROM_HERE be an alias of FROM_HERE as well. So that tasks posted
from Blink leaves a valid program counter and line number in the crash
dump.

Committed: https://crrev.com/3c109dd65c1984237444da93f7c7acc8b0bdcd92
Cr-Commit-Position: refs/heads/master@{#405736}
==========

[commit-bot: I haz the power, 2016-07-15 09:53:19]

Patchset 6 (id:??) landed as
https://crrev.com/3c109dd65c1984237444da93f7c7acc8b0bdcd92
Cr-Commit-Position: refs/heads/master@{#405736}

[nednguyen, 2016-08-05 20:03:53]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2218933003/ by nednguyen@google.com.

The reason for reverting is: Speculative revert: this CL may regress 
system_health.memory_mobile benchmark

BUG=629112.