Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2136993002: Reland "Add support for installing ARM64 sysroot" (Closed)

Created:
4 years, 5 months ago by apatole
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Add support for installing ARM64 sysroot" Fixed license and copyright script errors with earlier change by whitelisting newly introduced folder build/linux/debian_jessie_arm64-sysroot. This change modifies install-sysroot.py to add support for installing ARM64 sysroot. also upadted jessie arm64 package list. BUG=613452 R=thestig@chromium.org Committed: https://crrev.com/82242c1833949a8a5ae9708b4c5af65585f23b71 Cr-Commit-Position: refs/heads/master@{#404719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 3 chunks +11 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm64 View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/copyright_scanner/copyright_scanner.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
apatole
On 2016/07/11 11:12:31, apatole wrote: > mailto:apatole@nvidia.com changed reviewers: > + mailto:mmoss@chromium.org, mailto:phajdan.jr@chromium.org, mailto:thakis@chromium.org PTAL. ...
4 years, 5 months ago (2016-07-11 11:13:11 UTC) #3
Nico
lgtm fyi, the usual pattern for relands is to upload the original patch as patch ...
4 years, 5 months ago (2016-07-11 14:25:47 UTC) #4
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-11 15:33:27 UTC) #5
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-11 19:31:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136993002/1
4 years, 5 months ago (2016-07-11 19:32:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 20:12:31 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 20:14:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82242c1833949a8a5ae9708b4c5af65585f23b71
Cr-Commit-Position: refs/heads/master@{#404719}

Powered by Google App Engine
This is Rietveld 408576698