Bundle fake Widevine component manifest for stub CDM

chrome/chrome_dll_bundle.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file contains resources for the main Mac chromium bundle.
 {
   # The main browser executable's name is <(mac_product_name).
   # Certain things will get confused if two modules in the
   # executable share the same name, so append " Framework" to the
   # product_name used for the framework.  This will result in
@@ skipping 118 matching lines @@
         ['branding == "Chrome"', {
           'files': [
             '<(PRODUCT_DIR)/PepperFlash/PepperFlashPlayer.plugin',
             '<(PRODUCT_DIR)/PepperFlash/manifest.json',
           ],
         }],
       ],
     },
     {
       # The adapter is not a complete library on its own. It needs the Widevine
-      # CDM to work.
+      # CDM to work. The CDM and manifest are either the actual Widevine CDM
+      # and manifest or stubs used for testing only. The choice is made within
+      # the corresponding Widevine targets based on branding.
       'destination': '<(PRODUCT_DIR)/$(CONTENTS_FOLDER_PATH)/Libraries/<(widevine_cdm_path)',
-      'files': [],
-      'conditions': [
-        ['branding == "Chrome"', {
-          'files': [
-            '<(PRODUCT_DIR)/<(widevine_cdm_path)/libwidevinecdm.dylib',
-            '<(PRODUCT_DIR)/<(widevine_cdm_path)/widevinecdmadapter.plugin',
-          ],
-        }],
+      'files': [

[ddorwin, 2016/07/18 18:35:17]

Don't we still need a condition for Chrome || enable_widevine?

[wdzierzanowski, 2016/07/19 11:35:17]

Ah, of course. Thanks for catching it!

[wdzierzanowski, 2016/07/19 11:35:17]

Done.

+        '<(PRODUCT_DIR)/<(widevine_cdm_path)/libwidevinecdm.dylib',

[ddorwin, 2016/07/18 18:35:17]

It's not clear to me that putting the stub CDM or manifest in the bundle is the
correct thing to do since this will actually be in the app bundle. This works
fine for testing but you wouldn't want to ship it.

[wdzierzanowski, 2016/07/19 11:35:17]

You're right, this must not be shipped.

I'm a bit on the fence about it myself. On the one hand, Opera doesn't really
need this change. The target that builds the encrypted media browser tests
doesn't even use this and we need to take care of bundling Widevine for tests
separately anyway. I don't know about the other browsers.

On the other hand, adding the bundling here for enable_widevine==1 has the
advantage of making this and similar changes testable in a Chromium-branded
build. Currently, it's only testable in an official Chrome build AFAIK.

Given that we already have to make sure we don't ship the stub CDM that is
already put in the bundle by Opera-specific build files to enable its use in
tests, I'm leaning towards the latter though.

[wdzierzanowski, 2016/07/21 08:47:06]

I feel like I need to clarify some bits of what I wrote:
Here, by "this change" I actually meant just the changes to the build files in
chrome/.
 
This time around, "this change" refers to the entire CL.

Sorry for the confusing language :)

+        '<(PRODUCT_DIR)/<(widevine_cdm_path)/widevinecdmadapter.plugin',
       ],
     },
     {
       'destination': '<(PRODUCT_DIR)/$(CONTENTS_FOLDER_PATH)/Libraries/WidevineCdm',
-      'files': [],
-      'conditions': [
-        ['branding == "Chrome"', {
-          'files': [
-            '<(PRODUCT_DIR)/WidevineCdm/manifest.json',
-          ],
-        }],
+      'files': [
+        '<(PRODUCT_DIR)/WidevineCdm/manifest.json',
       ],
     },
     {
       # Copy of resources used by tests.
       'destination': '<(PRODUCT_DIR)/pseudo_locales',
       'files': [
           '<(SHARED_INTERMEDIATE_DIR)/<(pseudo_locales).pak'
       ],
     },
     {
@@ skipping 84 matching lines @@
       ],
     }],
     ['v8_use_external_startup_data==1', {
       'mac_bundle_resources': [
         '<(PRODUCT_DIR)/natives_blob.bin',
         '<(PRODUCT_DIR)/snapshot_blob.bin',
       ],
     }],
   ],  # conditions
 }