Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2136963002: PlzNavigate: Fix missing navigation information. (Closed)

Created:
4 years, 5 months ago by arthursonzogni
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Fix missing navigation information. The navigation type "blink::WebNavigationTypeReload" is now forwarded to the browser process. Two more tests pass when browser-side-navigation is enabled. http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload.html http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload.html BUG=576272 Committed: https://crrev.com/69824eb6bff5487e1fc8060bbc25d6b0eb01df65 Cr-Commit-Position: refs/heads/master@{#405179}

Patch Set 1 #

Patch Set 2 : PlzNavigate: Fix missing navigation information. #

Total comments: 1

Patch Set 3 : PlzNavigate: Fix missing navigation information. #

Patch Set 4 : PlzNavigate: Fix missing navigation information. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -48 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -12 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 6 chunks +37 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
arthursonzogni
4 years, 5 months ago (2016-07-11 11:10:09 UTC) #7
clamy
Thanks! Could you also remove the passing tests from third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation ? https://codereview.chromium.org/2136963002/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): ...
4 years, 5 months ago (2016-07-11 12:37:57 UTC) #8
arthursonzogni (do not use)
On 2016/07/11 12:37:57, clamy wrote: > Thanks! Could you also remove the passing tests from ...
4 years, 5 months ago (2016-07-11 12:55:27 UTC) #9
clamy
Thanks! Lgtm.
4 years, 5 months ago (2016-07-11 14:03:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136963002/60001
4 years, 5 months ago (2016-07-13 13:56:59 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 16:22:26 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 16:22:39 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:23:41 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/69824eb6bff5487e1fc8060bbc25d6b0eb01df65
Cr-Commit-Position: refs/heads/master@{#405179}

Powered by Google App Engine
This is Rietveld 408576698