Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2136943002: Exclude NaCl messages in ipc_fuzzer on DISABLE_NACL build (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 5 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude NaCl messages in ipc_fuzzer on DISABLE_NACL build ipc_fuzzer starts failing to link recently due to undefined symbols to NaCl messages on NaCl-disabled build. This CL fixes the error by excluding them on the problematic case. R=tsepez@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/82029469bf34c1ddd659cca8e43920e856df51c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/ipc_fuzzer/message_lib/all_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
tzik
PTAL
4 years, 5 months ago (2016-07-11 07:19:01 UTC) #3
tzik
I found that this is failing only on static_library build. component_build works fine. Feel free ...
4 years, 5 months ago (2016-07-11 08:27:49 UTC) #4
Tom Sepez
lgtm
4 years, 5 months ago (2016-07-11 17:26:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136943002/1
4 years, 5 months ago (2016-07-13 10:47:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217096)
4 years, 5 months ago (2016-07-13 10:54:53 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/82029469bf34c1ddd659cca8e43920e856df51c9 Cr-Commit-Position: refs/heads/master@{#405133}
4 years, 5 months ago (2016-07-13 13:00:26 UTC) #13
tzik
4 years, 5 months ago (2016-07-13 13:01:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
82029469bf34c1ddd659cca8e43920e856df51c9.

Powered by Google App Engine
This is Rietveld 408576698