Add ime.ExtendSelectionAndDelete Mojo RPC

Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=627009
BUG=b/30054874

Committed: https://crrev.com/37f05c11c66e4b85835d148395dc273eb6c5d2cf
Cr-Commit-Position: refs/heads/master@{#404624}

[takaoka, 2016-07-11 07:08:56]

Description was changed from

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=30054874
==========

to

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=30054874
==========

[takaoka, 2016-07-11 07:08:57]

takaoka@chromium.org changed reviewers:
+ dcheng@chromium.org, hidehiko@chromium.org, kinaba@chromium.org

[takaoka, 2016-07-11 07:09:12]

PTAL?
Thanks.

[takaoka, 2016-07-11 07:10:17]

Patchset #1 (id:1) has been deleted

[takaoka, 2016-07-11 07:11:55]

Description was changed from

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=30054874
==========

to

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=b/30054874
==========

[kinaba, 2016-07-11 07:43:56]

Thanks!

In addition to the inline reviews, please take care of tests.

https://codereview.chromium.org/2136933002/diff/20001/components/arc/common/i...
File components/arc/common/ime.mojom (right):

https://codereview.chromium.org/2136933002/diff/20001/components/arc/common/i...
components/arc/common/ime.mojom:78: 
nit: 1 blank line (not 2)

https://codereview.chromium.org/2136933002/diff/20001/components/arc/common/i...
components/arc/common/ime.mojom:80: // Deletes current selection plus the
specified number of characters before
Could you elaborate more on the "number of characters"?
(Is it the number of codepoints, or the number of char16 values, or ...?)

[takaoka, 2016-07-11 07:49:44]

Description was changed from

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=b/30054874
==========

to

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=627009
BUG=b/30054874
==========

[kinaba, 2016-07-11 08:05:21]

On 2016/07/11 07:43:56, kinaba wrote:
> Thanks!
> 
> In addition to the inline reviews, please take care of tests.
Ah, sorry, the compilation errors were not from tests... :p

[hidehiko, 2016-07-11 08:09:39]

https://codereview.chromium.org/2136933002/diff/20001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_service.cc (right):

https://codereview.chromium.org/2136933002/diff/20001/components/arc/ime/arc_...
components/arc/ime/arc_ime_service.cc:292: void
ArcImeService::ExtendSelectionAndDelete(uint32_t before, uint32_t after) {
size_t != uint32_t?

[takaoka, 2016-07-11 08:34:55]

PTAL?

https://codereview.chromium.org/2136933002/diff/20001/components/arc/common/i...
File components/arc/common/ime.mojom (right):

https://codereview.chromium.org/2136933002/diff/20001/components/arc/common/i...
components/arc/common/ime.mojom:78: 
On 2016/07/11 07:43:56, kinaba wrote:
> nit: 1 blank line (not 2)

Done.

https://codereview.chromium.org/2136933002/diff/20001/components/arc/common/i...
components/arc/common/ime.mojom:80: // Deletes current selection plus the
specified number of characters before
On 2016/07/11 07:43:56, kinaba wrote:
> Could you elaborate more on the "number of characters"?
> (Is it the number of codepoints, or the number of char16 values, or ...?)

Confirmed that "characters" means
char16.https://cs.chromium.org/chromium/src/ui/views/controls/textfield/textfield.cc?q=Textfield::ExtendSelectionAndDelete&sq=package:chromium

https://codereview.chromium.org/2136933002/diff/20001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_service.cc (right):

https://codereview.chromium.org/2136933002/diff/20001/components/arc/ime/arc_...
components/arc/ime/arc_ime_service.cc:292: void
ArcImeService::ExtendSelectionAndDelete(uint32_t before, uint32_t after) {
On 2016/07/11 08:09:39, hidehiko wrote:
> size_t != uint32_t?

Using uint64 for Mojo.

[kinaba, 2016-07-11 08:44:55]

lgtm

[hidehiko, 2016-07-11 09:04:19]

lgtm. dcheng@, could you take a look at .mojom file as an owner?

[dcheng, 2016-07-11 09:32:43]

rs lgtm

[takaoka, 2016-07-11 09:33:53]

The CQ bit was checked by takaoka@chromium.org

[commit-bot: I haz the power, 2016-07-11 09:34:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 09:38:05]

Description was changed from

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=627009
BUG=b/30054874
==========

to

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=627009
BUG=b/30054874
==========

[commit-bot: I haz the power, 2016-07-11 09:38:07]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-11 09:38:10]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 09:39:22]

Description was changed from

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=627009
BUG=b/30054874
==========

to

==========
Add ime.ExtendSelectionAndDelete Mojo RPC

BUG=627009
BUG=b/30054874

Committed: https://crrev.com/37f05c11c66e4b85835d148395dc273eb6c5d2cf
Cr-Commit-Position: refs/heads/master@{#404624}
==========

[commit-bot: I haz the power, 2016-07-11 09:39:23]

Patchset 2 (id:??) landed as
https://crrev.com/37f05c11c66e4b85835d148395dc273eb6c5d2cf
Cr-Commit-Position: refs/heads/master@{#404624}