Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 213693011: Replace RULE_INPUT_PATH with RULE_INPUT_DIRNAME/RULE_INPUT_ROOT.mojom (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Replace RULE_INPUT_PATH with RULE_INPUT_DIRNAME/RULE_INPUT_ROOT.mojom This is necessitated by the webview build, which does not use ninja and does not support RULE_INPUT_PATH. BUG=none TEST=none R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/mojom_bindings_generator.gypi View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
Doing this should mean we can build on android webview. So, I'm updating common.gypi at ...
6 years, 8 months ago (2014-04-03 22:02:28 UTC) #1
viettrungluu
rubberstamp lgtm
6 years, 8 months ago (2014-04-03 22:05:51 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-03 22:46:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/213693011/1
6 years, 8 months ago (2014-04-03 22:48:10 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 01:10:48 UTC) #5
Message was sent while issue was closed.
Change committed as 261621

Powered by Google App Engine
This is Rietveld 408576698