[Android] Block access to java.lang.Object.getClass in injected Java objects

[Android] Block access to java.lang.Object.getClass in injected Java objects

Throws a java.lang.SecurityException on Browser UI thread when an attempt is
made to execute java.lang.Object.getClass from JavaScript code via an injected
Java object.

BUG=359528
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261801

[benm (inactive), 2014-04-03 20:20:42]

LGTM.

+palmer for a look too.

[benm (inactive), 2014-04-03 20:23:00]

On 2014/04/03 20:20:42, benm wrote:
> LGTM.
> 
> +palmer for a look too.

My goodness, look at all the tests doing the exact thing we want to block :-(

[palmer, 2014-04-03 21:53:58]

LGTM, but see comments in the bug.

https://chromiumcodereview.appspot.com/213693005/diff/1/content/browser/rende...
File content/browser/renderer_host/java/java_bound_object.cc (right):

https://chromiumcodereview.appspot.com/213693005/diff/1/content/browser/rende...
content/browser/renderer_host/java/java_bound_object.cc:52: "Access to
java.lang.Object.getClass is blocked";
Nit: As you think of more bad classes/methods to block, you'll want to
generalize this.

[mnaganov (inactive), 2014-04-04 10:16:49]

Thanks, all!

I've fixed the tests, sorry for not having this done in the first place.

https://codereview.chromium.org/213693005/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/java/java_bound_object.cc (right):

https://codereview.chromium.org/213693005/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/java/java_bound_object.cc:52: "Access to
java.lang.Object.getClass is blocked";
On 2014/04/03 21:53:58, Chromium Palmer wrote:
> Nit: As you think of more bad classes/methods to block, you'll want to
> generalize this.

As I have explained in the bug, so far 'getClass' is the only thing we intend to
block.

[mnaganov (inactive), 2014-04-04 10:18:13]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-04-04 10:18:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/213693005/20001

[commit-bot: I haz the power, 2014-04-04 11:00:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-04 11:00:33]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[mnaganov (inactive), 2014-04-04 13:00:57]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-04-04 13:01:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/213693005/20001

[commit-bot: I haz the power, 2014-04-04 15:28:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/213693005/20001

[commit-bot: I haz the power, 2014-04-04 18:37:06]

Change committed as 261801