Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 213693004: Mojo: Mojom: Remove relational (e.g., !=) and logical operators (e.g., || and !). (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Mojom: Remove relational (e.g., !=) and logical operators (e.g., || and !). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260068

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M mojo/public/bindings/pylib/parse/mojo_lexer.py View 4 chunks +3 lines, -11 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser.py View 3 chunks +3 lines, -12 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser_unittest.py View 2 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-27 23:15:59 UTC) #1
darin (slow to review)
LGTM
6 years, 9 months ago (2014-03-27 23:35:01 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-28 01:04:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/213693004/20001
6 years, 9 months ago (2014-03-28 01:07:00 UTC) #4
viettrungluu
6 years, 9 months ago (2014-03-28 03:01:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r260068 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698