Issue 2136913002: GarbageCollectedFinalized<> must be the left-most class in IndexedDBClient

Issue 2136913002: GarbageCollectedFinalized<> must be the left-most class in IndexedDBClient (Closed)

Created:
4 years, 5 months ago by haraken

Modified:
4 years, 5 months ago

Reviewers:
oilpan-reviews, keishi, sof, kouhei (in TOK)

CC:
chromium-reviews, blink-reviews, haraken, jsbell+idb_chromium.org, cmumford

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

GarbageCollectedFinalized<> must be the left-most class in IndexedDBClient BUG= Committed: https://crrev.com/a75a9b232b44b176d840cf98f562c5a543e2c9c5 Cr-Commit-Position: refs/heads/master@{#404602}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 15 (7 generated)

haraken

PTAL This mis-ordering was not an issue (and thus not detected by the GC plugin) ...

4 years, 5 months ago (2016-07-11 04:48:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136913002/1

4 years, 5 months ago (2016-07-11 04:50:53 UTC) #8

commit-bot: I haz the power

4 years, 5 months ago (2016-07-11 06:00:31 UTC) #15

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a75a9b232b44b176d840cf98f562c5a543e2c9c5
Cr-Commit-Position: refs/heads/master@{#404602}