Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2136903002: With ChannelMojo, don't error the channel on Send failure. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

With ChannelMojo, don't error the channel on Send failure. This preserves behaviour with legacy IPC channels and avoids re-entrency in certain cases. BUG=626268 Committed: https://crrev.com/1e355dd1c2f07389153aad500c5d43e2c75eb51b Cr-Commit-Position: refs/heads/master@{#404736}

Patch Set 1 #

Patch Set 2 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M ipc/ipc_channel_mojo.cc View 1 1 chunk +16 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Anand Mistry (off Chromium)
4 years, 5 months ago (2016-07-11 04:57:44 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 5 months ago (2016-07-11 17:30:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2136903002/20001
4 years, 5 months ago (2016-07-11 21:28:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 21:33:45 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 21:33:47 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 21:35:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e355dd1c2f07389153aad500c5d43e2c75eb51b
Cr-Commit-Position: refs/heads/master@{#404736}

Powered by Google App Engine
This is Rietveld 408576698