Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 21369002: Speed-up 'new TypedArray(arrayLike)'. (Closed)

Created:
7 years, 4 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Speed-up 'new TypedArray(arrayLike)'. Handle specially the cases when the argument is a typed array, in particular of the same type as the one we create. Allocate backing store uninitialized in cases when we can guarantee complete initialization. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15998 Committed: https://code.google.com/p/v8/source/detail?r=16005

Patch Set 1 #

Total comments: 2

Patch Set 2 : References -> pointers (argh!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -50 lines) Patch
M include/v8.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/d8.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/runtime.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/runtime.cc View 1 4 chunks +138 lines, -43 lines 0 comments Download
M src/typedarray.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Lomov (no reviews)
PTAL
7 years, 4 months ago (2013-07-31 14:42:45 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/21369002/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/21369002/diff/1/src/runtime.cc#newcode814 src/runtime.cc:814: int arrayId, ExternalArrayType& array_type, size_t& element_size) { Use pointers ...
7 years, 4 months ago (2013-08-01 06:14:35 UTC) #2
Dmitry Lomov (no reviews)
On 2013/08/01 06:14:35, Benedikt Meurer wrote: > https://codereview.chromium.org/21369002/diff/1/src/runtime.cc > File src/runtime.cc (right): > > https://codereview.chromium.org/21369002/diff/1/src/runtime.cc#newcode814 ...
7 years, 4 months ago (2013-08-01 07:42:06 UTC) #3
Dmitry Lomov (no reviews)
Comments (very reluctantly) addressed.
7 years, 4 months ago (2013-08-01 07:44:35 UTC) #4
Benedikt Meurer
LGTM
7 years, 4 months ago (2013-08-01 08:09:45 UTC) #5
Dmitry Lomov (no reviews)
Committed patchset #2 manually as r15998 (presubmit successful).
7 years, 4 months ago (2013-08-01 08:19:57 UTC) #6
Dmitry Lomov (no reviews)
7 years, 4 months ago (2013-08-01 08:52:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r16005 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698